-
-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Pause, while I'm typing" Search || comment || chat. "Pause while scrolled down"[same moment as custom miniplayer] #2111
Comments
Hi @ImprovedTubeI noticed this open issue and I'm interested in tackling it. Can I take ownership of this and work on a solution? I believe I can contribute effectively to resolving it, I would love to start working on this issue as soon as possible You can also contact me via: henriquegabrielhs21@gmail.com. Thanks. |
thank you so much! @gabrielhsdev |
Thanks, @ImprovedTube ! I'll dive into it as soon as possible ( I will start working on the tasks on May 5th ) . Quick question: Would it be acceptable to create a separate pull request for each of the five tasks? Appreciate your guidance in advance. |
I apologize for the delay in addressing this issue. Over the past month, I've been dealing with a challenging schedule due to university and work commitments. I am now able to focus on this task and will start development immediately. I will provide updates on each feature as I progress. Thank you for your patience and understanding. This comment is to update you on my current status. Best regards. |
@ImprovedTube |
I hope you're doing well. I have just submitted a pull request for the first task on the list: "Pause while typing on youtube.com." When you have a moment, could you please review it? Thank you for your time and consideration. Updated Task List (I will update the checkboxes as I complete each task):
|
Hi! @gabrielhsdev
Thank you for the intellectual fulfillment! (For this project it also is increasingly relevant, that we nest/sort/structure our toggles) #2336: Didnt test yet. (starting with checking storage, it couldn't go wrong.) |
in what use-case might #2336 require the video to be visible? |
Thank you for the feedback @ImprovedTube I'm glad to have noticed the list and contributed to it. Here are my thoughts on the points you mentioned: Task #1565: The smart (combined) key event-chain analysis sounds like a great addition. I can see how this could provide valuable insights. Once I finish developing the current issue, I'll look into this task and see how we can integrate it effectively. Issue #2336: Noted on this. It’s good to know about the storage check and the potential for using the existing keydown Eventlistener to avoid redundancy. I am actively working on and reviewing the tasks. I will submit my pull request next week after my university exams are finished. |
...i think it is motivating to connect some dots - hopefully not to overwhelm or ask too much. let me and us know everything you might have to share sooner or later! ( labeling as important/critical because of your wonderful participation & motivation.) |
@ImprovedTube Thanks :) |
hi! @gabrielhsdev |
"Pause while typing on youtube.com"
and/or:
"Pause while the player isn't well visible"
[same moment as custom miniplayer appears?]"Pause for X seconds when leaving the tab, default: 8 seconds for a deep breath and focus on whatever makes us leave the tab"
"Pause while i type in any tab"
"Pause when i work fast in another tab
(When there is a high keyboard and/or mouse/click-speed.) (requires all sites permission)"Pause when inactive. And revert/skip back to where i might left."
, for example in a visible youtube tab, after 80 seconds of HID inactivity, it could pause and skip back those 70 seconds (or a custom amount) - while inactivity could count soon (40 seconds?) when the video is playing in the background (or the viewport (=player) isn't visible, or playing as PiP.), While In full-screen mode (,cinema mode, and theater mode to some lesser extent), this feature might not be wanted since the user already decides to be inactive when entering full-screen mode, unless it would be smart like using webcam)All of which might be structured as sub-options of auto-pause
All of which might have an exclusion such [when the video is music] (existing in our speed-watching feature)
The text was updated successfully, but these errors were encountered: