Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1. Dynamic instant Search: if(1-3 chars){might be a shortcut?} if(2-10chars){a Search? a part of the transcript or top comments?} & 2. How to preventing accidental single letter shortcuts? #1566 #2437

Open
4 tasks
ImprovedTube opened this issue Jul 3, 2024 · 0 comments
Labels
Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@ImprovedTube
Copy link
Member

if there is a string input or "keyboard event-chain" (above 1 chars) (and not in a form field), then that is likely..!..a search!...
(except for ctrl, but most shortcuts might be much less popular than we feel here (even ctrl+f). (Few percent of global internet users might use shortcuts beyond ctrl+c ctrl+v , just more among us afaik).

  • And if there are matches from the transcript of the current video, then those should appear on top of Youtube's regular search suggestions = search history) Showing transcript results need not depend on the amount of characters but amount of transcript matches. I.e. the string "and " might have 0 matches in the transcript already - or 120. But whenever there are 1-5 matches, that must be perfectly relevant to search for, ( while the maximum of matches to be considers might be proportional to the duration of the video and minutes of playback time done and session-duration until a certain maxium. )
    Youtube Screenshots could appear too, in the top right or so, next to youtube's )
  • Same for searching in comments would be too (integrating the code from https://github.com/sonigy/YCS ?) (limited to the top comments, but especially considering all comments with time-marks. (And more/all/top10000 as a sub-option)
  • Also if a user ever happens to type a word on Youtube like autoplay, transcript or codec then results from Improvedtube (in the top right or so, next to youtube's results)

The compatibility issue: Single-letter-Shortcuts:

While Youtube's shortcuts consisting of a single letter are mostly used accidentally (k j l f i c o w m #1566), for the users, who do use them, or even set others with our shortcuts.js, they could be undone (if not aborted), if a 2nd letter follows within 0.3s (+/-0.2s, depending typing speed) - especially if the input reveals to be language string/word already including a vowel (very common - and not a row of these shortcut consonants (out of which only repeated letters and jjjl or llj might be common).

  • even a slow typer might release each letter key again fast like 0.1s again, if it is part of a word, while an intentional hotkey might be pressed in a row for much longer, like 0.8s
  • while little things and even pause or skip-backwards can be undone nicely, fullscreen (theater, mini player) might (looks) more annoying even to happen for 0.3s, so for users of these hotkeys if will be harder to provide this smart input interpretation. Besides that it would be nice if we add smooth transition/animation to them anyways.
  • Also skip-forward 10s would at best be undone by skipping backwards 10.3s then. - Equally undoing m (mute) would potentially required to skip back 0.3s not to miss a sound/word maybe.
  • So in the end, when enabling this feature we have to ask users to: Disable at least the youtube hotkeys: l f t i m (#1566) ( or add a delay or change them. )
    • Because to offer this by default, the code would have to count, if any of these is used are used within the next 20 Youtube-hours or so. And intentionally, while the accidental could be identified through being undone (by the mouse) soon /immediately).
      • (and we should rather first show "my active features" and our few defaults on our home screen, before planning another default setting.)

Our search is minimal yet: #1171, #748

@ImprovedTube ImprovedTube added Feature request Wish or idea help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Jul 3, 2024
@ImprovedTube ImprovedTube changed the title Preventing accidental single letter shortcuts? if(1-3 chars){might be a shortcut?} if(2-10chars){a Search? a part of the transcript or top comments?} 1. Dynamic instant Search: if(1-3 chars){might be a shortcut?} if(2-10chars){a Search? a part of the transcript or top comments?} & 2. How to preventing accidental single letter shortcuts? #1566 Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
None yet
Development

No branches or pull requests

1 participant