bug: can set the same shortcut as YouTube (=twice). Please Review our shortcuts.js vs. youtube defaults.

[ImprovedTube]

Please review how our shortcuts.js interacts with youtube's defaults

• BUG: It is possible to set space for pause additionally next to youtube's default - so it will trigger twice (unless the user gets the idea to reset it.). ( maybe this only started with the latest Youtube update these days @IntrepidWanderer )

  • We gotta ignore or forbid when the same as youtube's default is set a / same as our "reset" button.

    • in our menu pause is the only one thats different. However changing this only seems to have no other effect.

      youtube/menu/skeleton-parts/shortcuts.js

      Lines 180 to 190 in 673aeb5

      	shortcut_play_pause: {
      	component: 'shortcut',
      	text: 'playPause',
      	value: {
      	keys: {
      	32: {
      	code: 'space'
      	}
      	}
      	}
      	},

      • ( To be shown like the others it should say key: "space" or key: " ")

        youtube/menu/skeleton-parts/shortcuts.js

        Line 186 in 673aeb5

        code: 'space'

[ImprovedTube]

https://forum.vivaldi.net/topic/93715/fixed-by-deactivated-extension-youtube-page-in-vivaldi-disrespects-key-shortcuts/18

[raszpl]

YT reacts to Space keyup event, we only cancel keydown!