Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoplay broken #1594

Open
1 task done
Eisys opened this issue Mar 3, 2023 · 9 comments
Open
1 task done

Autoplay broken #1594

Eisys opened this issue Mar 3, 2023 · 9 comments
Labels
Bug Bug or required update after YouTube changes help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) related thread/s exist/s. (Link or consolidate maybe) Thanks!! up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@Eisys
Copy link

Eisys commented Mar 3, 2023

Bug Report:

BUG: Autoplay is enabled. Subs/Home page; middle click a video, it opens in a new tab. Open that tab. Video is paused for half a second, a second, etc. Then starts playing normally.

  • youtube.com/'InsertChannelName'/videos. Click on a video. Video page loads but video does not play unless I click on it, press Space, etc to start it.

HOW: null

EXPECTED (/preferred) behavior: Autoplay being enabled should keep whatever default Youtube behaviour.
Imho 'Enabled' should disable all autoplay related code in ImprovedTube to stop it from messing with the player and causing such bugs.

Screenshots: null
/ ⚬ Context: null

Setup:

⚬ ImprovedTube Version: 4.0.17
⚬ Browser: Chrome Version 111.0.5563.50 (Official Build) beta (64-bit)
⚬ Settings: It happens with a fresh install of ImprovedTube.
⚬ OS: Windows 11 Pro
⚬ Device: null

@Eisys Eisys added Bug Bug or required update after YouTube changes help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) labels Mar 3, 2023
@ImprovedTube
Copy link
Member

Hi @Eisys! Thanks, a new version is pending webstore review. You also can try our beta webstore version maybe.

@Eisys
Copy link
Author

Eisys commented Mar 5, 2023

Thanks for the update.

The first part of the problem still happens on the Beta version 4.0.35
Clicking a video while on a channel's page, however, is working there.

MohamedLebda added a commit to MohamedLebda/ImprovedTube-for-YouTube that referenced this issue Mar 5, 2023
MohamedLebda added a commit to MohamedLebda/ImprovedTube-for-YouTube that referenced this issue Mar 6, 2023
@RedSnt
Copy link

RedSnt commented Mar 6, 2023

I can confirm that this bug seems fixed in the beta version. I've had it for weeks, if not months, and just never got around to reporting it because I thought I had the autoplay disabled using a userscript. Thanks for the hard work!

@RedSnt
Copy link

RedSnt commented Mar 7, 2023

So I visited reddit and tried viewing an embedded video from Youtube there, and ImprovedTube went bananas, trying to reset the video to 0 seconds (or refreshing?) constantly as it wasn't able to properly "hook" the pause function. This was using Beta v. 4.0.36.

EDIT: Turns out this wasn't related to this issue at all, I got totally in my head that it was though, sorry for the confusion.

ImprovedTube added a commit that referenced this issue Mar 10, 2023
@ImprovedTube
Copy link
Member

ImprovedTube commented Mar 13, 2023

Autoplay being enabled should keep whatever default Youtube behaviour.
Imho 'Enabled' should disable all autoplay related code in ImprovedTube to stop it from messing with the player and causing such bugs.

@Eisys exactly! and maybe it should be called "No autoplay" after all. Or maybe we should not have switches "on" by default just representing Youtube's defaults, but rather a whole list, category of things called: "Trashbin" / things to avoid

@ImprovedTube
Copy link
Member

@Eisys what about now / v4.4 ?

@ImprovedTube ImprovedTube added the up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ label Apr 29, 2023
@raszpl
Copy link
Contributor

raszpl commented May 4, 2023

"No autoplay" "Disable autoplay" is much better
same goes for options like "Allow 60fps", its not allowing anything and works in reverse, should be called "Disable >30fps"

@Eisys
Copy link
Author

Eisys commented May 4, 2023

Still happening on version 4.9.

Even on a brand new install of Chrome on a "brand new" install of Win 11(Windows Sandbox), with only ImprovedTube and Ublock Origin added.
Ublock Origin was installed because ImprovedTube didn't disable ads with 'General' -> 'Ads' set to off.

ImprovedTube added a commit that referenced this issue Jan 12, 2024
@raszpl
Copy link
Contributor

raszpl commented Mar 4, 2024

#2042

@ImprovedTube ImprovedTube added the related thread/s exist/s. (Link or consolidate maybe) Thanks!! label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug or required update after YouTube changes help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) related thread/s exist/s. (Link or consolidate maybe) Thanks!! up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
None yet
Development

No branches or pull requests

5 participants