Subtitle language chain of priority L1>L2's (1st & 2nd Languages) human-authored OR (auto-translated VS. audio2text)

[FuSan21]

scroll down (edit by @ImprovedTube)

Bug Report:

⚬ BUG:
"Allow auto generate" and "Language" option interfering with the Subtitles option. When a subtitle is available in video natively it will not turn on the subtitle at all. "Subtitles", "Allow auto generate", "Language" all 3 of these options needs to be turned on for the bug to happen.

⚬ HOW:

1. Turn on Subtitles from "Player/Subtitles"
2. Turn on Allow auto generate from "Player/Subtitles"
3. Set Language to "English" from "Player/Subtitles"
4. Check the video https://www.youtube.com/watch?v=2eOg5DoYuwU (or any other video that has native English subtitles available)

⚬ EXPECTED (/preferred) behavior:
The subtitle is shown when all 3 previously mentioned options are set/turned on.

⚬ Screenshots:

Setup:

⚬ ImprovedTube Version: 4.6.1
⚬ Browser: Edge 111.0.1661.54
⚬ OS: Windows 11
⚬ Device: Desktop

[ImprovedTube]

Thank you! @FuSan21
so this might be a bug our relatively young feature always had?
Somebody in firefox review said it started ~1 month ago. However we had no updates then until 2 weeks ago

[ImprovedTube]

Since allow auto generate was added, as a subroutine of subtitlesLanguage ( pull request ( 1dfdc7d by @chiming93 ).

• auto generate === true requires auto generated subtitles, else toggles subtitles, even when human-written would be available.

• auto generate === false requires non-auto generated subtitles, else toggles subtitles

• it toggles subtitles, when allow auto generate is not set in storage

  • it is neither true nor false by default.
    • we should change that for more intuitive development)

bug-fix (all in one line):

youtube/js&css/web-accessible/www.youtube.com/player.js

Line 129 in 28cbbbf

if( false === tracklist[i].vss_id.includes("a.") || true === this.storage.auto_generate){

• also made this sub-feature appear accordingly only when the language is set

• prior to this @chiming93's PR it also gave the language name to the youtube player, now only the code. guess that doesn't matter

[ImprovedTube]

• Our Subtitles Switch is equal to both Youtube settings (always show subtitles & generated ones too) https://www.youtube.com/account_playback
  • its only required for people who dont log in to Google/Youtube. We can make an extra section for them in future.
  • we can split it in two buttons too

---

We have been asked about subtitle languages many times. Please come together to specify the ultimate plan. @FuSan21 #628 @yagamiyakumo @engineerbaraazakariya @WesselKroos @gregiv @franktntx @ausers @KovalevArtem #348 #259 @tympapost

[ImprovedTube]

What's really missing is a chain of priority:

• 1. priority: human-authored

  • Example Person: 1st-language: Javanese (99%), 2nd-language: Indonesian (60%), 3rd-language: English(40%), 4th language: Sundanese(20%) )

• 2. priority: generated audio2text, if the user speaks the audio's language well

• 3. priority: auto-translated, only if human-authored is available in another language,
  that translate.google is ok with
  & if also the user speaks a language, that translate.google also good with.

• 4. priority: generated audio2text that also requires auto-translation (again only if translate.google is good enough with both original & target language)

• Google-translate understandability
  

• +1. we can also allow to self-assess knowledge of secondary languages. For example somebody rates themselves only 40% in English. That can be expected to be better than having to auto-translate to Hindi or Thai.

( from #1543 )