autoplay quickfix

[ImprovedTube]

AirRaid
Videos don't always auto-pause when navigating to them. Is there something I should look for; other than disabling Player\Auto-play?

AirRaid
And yeah, confirming - it was pageType === "video" and pageType === "channel"

• undoing the use of the pageType function for now: 4491a2c
  • the original author might had a reason not to use that there.

youtube/js&css/web-accessible/functions.js

Lines 246 to 258 in 2a88783

	ImprovedTube.pageType = function () {
	if (/\/watch\?/.test(location.href)) {
	document.documentElement.dataset.pageType = 'video';
	} else if (location.pathname === '/') {
	document.documentElement.dataset.pageType = 'home';
	} else if (/\/subscriptions\?/.test(location.href)) {
	document.documentElement.dataset.pageType = 'subscriptions';
	} else if (/\/@|(\/(channel|user|c)\/)[^/]+(?!\/videos)/.test(location.href)) {
	document.documentElement.dataset.pageType = 'channel';
	} else {
	document.documentElement.dataset.pageType = 'other';
	}
	};

• also the timing of above function is slightly later through: f5d8593
  • as of:
    

    youtube/js&css/extension/init.js

    Lines 58 to 65 in 2a88783

    	extension.inject([
    	'/js&css/web-accessible/core.js',
    	'/js&css/web-accessible/functions.js',
    	'/js&css/web-accessible/www.youtube.com/appearance.js',
    	'/js&css/web-accessible/www.youtube.com/themes.js',
    	'/js&css/web-accessible/www.youtube.com/player.js',
    	'/js&css/web-accessible/www.youtube.com/playlist.js',
    	'/js&css/web-accessible/www.youtube.com/channel.js',

[ImprovedTube]

dc0dc71

[raszpl]

There must be another more efficient way of disabling autoplay. Current

youtube/js&css/web-accessible/functions.js

Line 296 in f6e49b1

HTMLMediaElement.prototype.play = (function (original) {

still allows for a sub second play time and fetches few seconds of video to a buffer :(. On the other hand YT detects if viewport is visible/tab active and will not start playing at all if you open YT page in the background until you switch to that tab.

[ImprovedTube]

There must be another more efficient way of disabling autoplay. Current

youtube/js&css/web-accessible/functions.js

Line 296 in f6e49b1

HTMLMediaElement.prototype.play = (function (original) {

still allows for a sub second play time and fetches few seconds of video to a buffer :(. On the other hand YT detects if viewport is visible/tab active and will not start playing at all if you open YT page in the background until you switch to that tab.

hi! @raszpl, btw

should we try the stop() function as possible or repeatedly within 0.x seconds?
@dodieboy thought about this before after youtube removed a function.

this one:

youtube/js&css/web-accessible/functions.js

Lines 173 to 176 in 6f6a592

	} else if (id === 'movie_player') {
	if (!this.elements.player) {
	ImprovedTube.elements.player = node;
	// if (this.storage.player_autoplay === false) { ImprovedTube.elements.player.stopVideo(); }

was placed critically/misplaced, because depending what changes over time during the sessions, our mutation handler could reach there too (https://github.com/code-charity/youtube/blob/master/js%26css/web-accessible/init.js )

[raszpl]

stop() function as possible or repeatedly within 0.x seconds?

pause works fine in other extensions, just need to slightly rework where its being called
as for reliably pausing every time this needs to be removed

youtube/js&css/web-accessible/www.youtube.com/player.js

Lines 18 to 21 in 7014a79

	{if (!ImprovedTube.autoplayDeniedOnce) {
	setTimeout(function () { video.pauseVideo(); });
	ImprovedTube.autoplayDeniedOnce = true;
	} else { console.log("autoplay:off - should we pause here again?"); } }

I have no idea what its for, but its breaking autoplayDisable

[ImprovedTube]

#2157 (comment)