Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playlist Size Too Small #1718

Closed
jpeg9999 opened this issue Jul 28, 2023 · 9 comments
Closed

Playlist Size Too Small #1718

jpeg9999 opened this issue Jul 28, 2023 · 9 comments
Assignees
Labels
Completion to revise (rethink, improve, tweak) (this feature or structure) CSS Solution can be CSS? else please specify (JS might only be needed to inject the CSS) good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@jpeg9999
Copy link

jpeg9999 commented Jul 28, 2023

PROBLEM:
Love the extension BTW. When ImproveYoutube is activated, the playlist only takes up about 1/2 the sidebar, but does not behave this way without extension active. With regular Youtube, the playlist is the same height as the video--this is what users are accustomed to--especially us who use the playlist a lot.

I see there are options within the extension to hide or collapse related videos, but this does not increase the size of playlist.

Issue#1718

SOLUTION:
It would be wonderful to have a sidebar option so the playlist can be normal size (same height as video).

//
Thank you!

@jpeg9999 jpeg9999 added Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Jul 28, 2023
@DarshanDixit05
Copy link

Hey, I want to work on this issue. Can you please assign it to me?

@jpeg9999
Copy link
Author

Hey, I want to work on this issue. Can you please assign it to me?

How does it get assigned?

@DarshanDixit05
Copy link

The one with the write access to the repo, anyways I'm working on it locally.

@jpeg9999
Copy link
Author

The one with the write access to the repo, anyways I'm working on it locally.

sweet

@D-Rekk
Copy link
Contributor

D-Rekk commented Jul 29, 2023

Hello! First of all I'm culprit thanks for noticing this feature/bug🥲

Why is my playlist so smol?😧

What happened is that, while I was working on this awesome Sidebar feature, I noticed that the playlist height was quirky with the extension on:

I could've applied more JavaScript, but I only style with JS if strictly necessary. Eventually what I did was to apply a fixed height as global CSS:
html[data-page-type=video] #playlist #items { max-height: calc(70px * 4 + 4px) ;
padding-bottom: 0;} /* MIGHT FIX #1693, currently shows up to 4 videos */

As you saw the playlist shows a max 4 videos right now.

How come?

Honestly this was chosen specifically for the Comments-Sidebar feature because comments and playlist would share the same container so a small number brought many benefits:

  • Playlist wouldn't fill most of the viewport height
  • Comments would start being fetched
  • I found aesthetically pleasing to have a fixed integer rather than having 7,2 or 5,4 videos showing as you resize the window.
Screenshot 2023-07-29 alle 21 54 42

What can we do to improve?

  • Change the style to be applied only on Comments -> Sidebar enabled, but probably the no-scrollbar bug will reappear
  • Convert the fixed number of videos to a CSS variable and be able to set that number in the settings (a new feature✨)
  • Resize Playlist height with JavaScript, bringing the original behavior
  • Other you suggest
  • Nothing, it's fine?

Let me know what you think

@D-Rekk D-Rekk added Completion to revise (rethink, improve, tweak) (this feature or structure) CSS Solution can be CSS? else please specify (JS might only be needed to inject the CSS) and removed Feature request Wish or idea up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Jul 29, 2023
@jpeg9999
Copy link
Author

jpeg9999 commented Jul 29, 2023

is there anything i can add in Settings/Developer Options/CSS or Javascript to override the fixed height?

well i changed 4 to 8 and loaded unpacked. i feel like most people want the playlist to be normal size.

@ImprovedTube
Copy link
Member

hi guys & thanks

assignment

thanks @DarshanDixit05 chances that two people work on it at once are still low. I can invite you guys to the team so you can also assign & tag/label

@ImprovedTube
Copy link
Member

ImprovedTube commented Aug 4, 2023

{ max-height: calc(70px * 4 + 4px) padding-bottom: 0;}

&

  • we can avoid running anything with no settings.
    • so this can depend player size set or comments sidebar being set:
      html[data-page-type=video][it-comments-sidebar='true'] #playlist #items,
      html[data-page-type=video]:not([it-player-size]) #playlist #items,
      html[data-page-type=video]:not([it-player-size='do_not_change']) #playlist #items
      { max-height: ... }
    • same for the JS resizing by @D-Rekk

@ImprovedTube ImprovedTube added the up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ label Aug 4, 2023
ImprovedTube added a commit that referenced this issue Aug 7, 2023
@D-Rekk
Copy link
Contributor

D-Rekk commented Aug 21, 2023

Since this is applying only on [it-comments-sidebar='true'] I'm closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completion to revise (rethink, improve, tweak) (this feature or structure) CSS Solution can be CSS? else please specify (JS might only be needed to inject the CSS) good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
None yet
Development

No branches or pull requests

4 participants