Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding "| WaterTower" and "Soundtrack" to music playback speed exception #1776

Closed
Eyevou opened this issue Sep 28, 2023 · 11 comments
Closed

Consider adding "| WaterTower" and "Soundtrack" to music playback speed exception #1776

Eyevou opened this issue Sep 28, 2023 · 11 comments
Labels
Completion to revise (rethink, improve, tweak) (this feature or structure) good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@Eyevou
Copy link

Eyevou commented Sep 28, 2023 •
edited
Loading

WaterTower Music is the music label for WB. All of their music seems to end in "| WaterTower". Also adding "Soundtrack" seems like a good idea too.

https://www.youtube.com/@WaterTowerWB

Wasn't sure if I should label this as a suggestion or bug. 😂
@Eyevou Eyevou added Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Sep 28, 2023
@Eyevou Eyevou changed the title Consider adding "| WaterTower" to music playback speed exception Consider adding "| WaterTower" and "Soundtrack" to music playback speed exception Sep 28, 2023
@ImprovedTube ImprovedTube added Completion to revise (rethink, improve, tweak) (this feature or structure) and removed Feature request Wish or idea labels Sep 28, 2023
ImprovedTube added a commit that referenced this issue Sep 28, 2023
@ImprovedTube
#1776 the word soundtrack usually means music
bdc9e0e
@ImprovedTube
Copy link
Member

hi @Eyevou

Soundtrack

added 👍 bdc9e0e

did you run into videos that weren't matched? (will be great if you can mention each and every)

Wasn't sure if I should label this as a suggestion or bug. 😂

we can make another issue template

"| WaterTower"

sounds fine if we check for the spelling too? We could collect / generate a list of 1000s of names as regex are fast, besides i don't have such list today and we didn't test our universal logic much yet.

@Eyevou
Copy link
Author

Eyevou commented Sep 28, 2023 •
edited
Loading

did you run into videos that weren't matched? (will be great if you can mention each and every)

There are FAR too many to fully mention but the entire Fionna and Cake Soundtrack would be on that list.

Examples:
https://www.youtube.com/watch?v=sm7oq4JdqSk (Adventure Time: Fionna and Cake Soundtrack | Prismo the Wishmaker - Amanda Jones | WaterTower)
https://www.youtube.com/watch?v=ZVNMFQnUlsw (Adventure Time: Fionna and Cake Soundtrack | Fionna's Wish - Amanda Jones | WaterTower)

Playlist here: https://www.youtube.com/playlist?list=PLBKadB95sF44oQX0bffOd9_1mdKuQtDrZ

sounds fine if we check for the spelling too?

"WaterTower" is the label, sometimes they use "WTM" as well. Sometimes they include "Soundtrack" or "Official" in their titles. The ones with official were being picked up but the others... not so much. lol

commit

Thanks, that should catch most of the ones I found!

@Eyevou
Copy link
Author

Eyevou commented Sep 30, 2023

https://www.youtube.com/watch?v=EY6-lb9RQEg (Adventure Time: Fionna and Cake | Everything in You (Live Ukulele Version) - Half Shy | WaterTower)

Was not picked up by the filters. used #OfficialSoundtrack in the description.

@ImprovedTube
Copy link
Member

thanks!

  • WatchTower got the category "entertainment" and there is/was a typo making checking for duration & music keywords fail always. (seems it only worked based on category music yet (minus exclusions) )

  • also it seems -tags data stays the same, when the next video starts in the same tab.
    see when playing non-music after music.

thanks

@shreyansh1410
Copy link

Hey @ImprovedTube is there any issue for a beginner in open source development?

@ImprovedTube ImprovedTube mentioned this issue Oct 6, 2023
Closed
@Eyevou
Copy link
Author

Eyevou commented Oct 10, 2023

https://www.youtube.com/watch?v=nnkKM4cM_TA
【Hololive Song / Gawr Gura Sing 唱歌】Hajimete no Chuu / はじめてのチュウ / 初吻 (with Lyrics)

Consider adding "Lyrics" to the speed exception?

@ImprovedTube
Copy link
Member

thanks!

  • WatchTower got the category "entertainment" and there is/was a typo making checking for duration & music keywords fail always. (seems it only worked based on category music yet (minus exclusions) )

  • also it seems -tags data stays the same, when the next video starts in the same tab.
    see when playing non-music after music.

thanks

will upload the fix to the stores soon.

@Eyevou
Copy link
Author

Eyevou commented Oct 12, 2023

thanks!

  • WatchTower got the category "entertainment" and there is/was a typo making checking for duration & music keywords fail always. (seems it only worked based on category music yet (minus exclusions) )

  • also it seems -tags data stays the same, when the next video starts in the same tab.
    see when playing non-music after music.

thanks

will upload the fix to the stores soon.

oops! I really should swap/update versions before making reports, my apologies.

@ImprovedTube
Copy link
Member

nono, regret it's not everywhere just yet (been a while) (and could have a faster process using the store's api's)

looking forward to your next message! 🥰

@Eyevou
Copy link
Author

Eyevou commented Oct 28, 2023

https://www.youtube.com/watch?v=Ge10aHNIWKU (Someone To You - Ranking of Kings AMV)

Consider adding "AMV"?

AMV is shorthand for Anime Music Video, btw.

ImprovedTube added a commit that referenced this issue Oct 28, 2023
@ImprovedTube
#1776 #1750 music identifier "AMV" anime music video
473d7ac
@ImprovedTube
Copy link
Member

ImprovedTube commented Oct 28, 2023 •
edited
Loading

good one! 26 million google results for site:youtube.com AMV
still 22 million for site:youtube.com [ AMV ]

473d7ac
4147666
c72bd4d

@ImprovedTube ImprovedTube mentioned this issue Nov 6, 2023
Open
@ImprovedTube ImprovedTube mentioned this issue Nov 6, 2023
Open
ImprovedTube added a commit that referenced this issue Jan 12, 2024
@ImprovedTube
#1776 the word soundtrack usually means music
c821a4b
ImprovedTube added a commit that referenced this issue Jan 12, 2024
@ImprovedTube
#1776 #1750 music identifier "AMV" anime music video
51126ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Completion to revise (rethink, improve, tweak) (this feature or structure) good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ImprovedTube @Eyevou @shreyansh1410