-
-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video and Playlist popup buttons #1805
Comments
added playlist to video popup button ( code-charity#1805 [1] )
WIP of code-charity#1805 [2] Idea is to have a popup button in every playlist menu (mini player with playlist / video page with playlist / playlist page)
By the way, for Chromium users, I can suggest the Open-as-Popup extension to toggle the popup back to a normal tab...to put back to all the other tabs...or open as popup again, because somehow this extension can get rid of the URL bar, making the popup-window even more minimal in appearance... |
|
the following also doesnt hide the URL bar. whats the trick?
|
I don't know for sure, but after some searching, I only found that it's not possible to hide the URL bar with But if one has access to a terminal, then |
the extensions work though with the chrome/browser API and |
I just noticed that the video popup button has issues and checked the code and the commit from #1813 is somehow reverted but without any revert commit. the fix ( #1813 ): youtube/js&css/web-accessible/www.youtube.com/player.js Lines 737 to 743 in 43d0cd3
is now back to (most recent state):
which has the same issues as in #1812, but there is no commit that has the lines marked as deleted and when looking at the git blame it shows the commits from #1806 and not #1813 as expected. |
hi! @MAZ01001 7fbb43fcomplicated :D (and maybe takes longer to load now?) ( there also is "panel"? yet cant apply for this permission it seems https://stackoverflow.com/questions/26250131/difference-between-a-chrome-popup-and-panel ) |
added playlist to video popup button ( #1805 [1] )
WIP of #1805 [2] Idea is to have a popup button in every playlist menu (mini player with playlist / video page with playlist / playlist page)
Feature request
[1] Video popup button should include the playlist (add support)
[1] has been merged ( #1806 & #1813 & #1834 )
[1] What
When opening a video within a playlist via the popup button (Player→Butttons→Popup player), it opens the video but not with the playlist.
Video:
https://www.youtube.com/watch?v=CBIQNiNBbYs?list=PLTfxJETd3IiArIOQSSYLAsYXui34D1cnW
Video-Popup:
https://www.youtube.com/embed/CBIQNiNBbYs?start=25&autoplay=1
Does not include the playlist ID (
list
).[1] Implementation
When opening the popup, if the current URL includes a
list
parameter, add it to the embed URL.Video:
https://www.youtube.com/watch?v=CBIQNiNBbYs?list=PLTfxJETd3IiArIOQSSYLAsYXui34D1cnW
Popup:
https://www.youtube.com/embed/CBIQNiNBbYs?start=25&autoplay=1&list=PLTfxJETd3IiArIOQSSYLAsYXui34D1cnW
Something like this:
youtube/js&css/web-accessible/www.youtube.com/player.js
Lines 726 to 732 in 454b460
↓ modify as follows ↓
[2] playlist popup button (new)
[2] has been merged ( #1832 )
[2] What
Add a button to the playlist window (
ytd-playlist-panel-renderer
) like the playlist reverse button ( #1544 ) or sites likeyoutube.com/playlist?list=...
that opens that playlist embed page.Playlist:
https://www.youtube.com/playlist?list=PLTfxJETd3IiArIOQSSYLAsYXui34D1cnW
Playlist-Popup:
https://www.youtube.com/embed/videoseries?list=PLTfxJETd3IiArIOQSSYLAsYXui34D1cnW
[2] Implementation
For the playlist window, the same functionality as in [1] Implementation can be used, but instead of
/embed/<video-ID>?list=<playlist-ID>
it's/embed/videoseries?list=<playlist-ID>
.I'd say It can be an option like the video popup button (default off) under the playlist menu of the extension, maybe "popup playlist".
This probably goes in js&css/web-accessible/www.youtube.com/playlist.js, but I don't understand enough about the project to know where else to add things.
Workaround
Bookmark can now also be found here: code-charity/bookmarklets-hub/yt_popup_player.md
In the meantime, I made myself (and you reading) a quick workaround (updated to #1813 ).
Navigate to a YouTube video or playlist page, open dev-console (F12), and copy & paste the following.
Or, even better, create a bookmark with any name and use the following as the URL (above JS minified).
Then, you can click on the bookmark to open the video or playlist as a popup.
The text was updated successfully, but these errors were encountered: