Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No button to add channels to blocklist #1971

Open
jahed opened this issue Jan 28, 2024 · 12 comments
Open

No button to add channels to blocklist #1971

jahed opened this issue Jan 28, 2024 · 12 comments
Assignees
Labels
Bug Bug or required update after YouTube changes Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ YouTube changed

Comments

@jahed
Copy link

jahed commented Jan 28, 2024

Bug Report:

I've enabled the block list feature but there is no way to add a channel to the blocklist. Looking at previous issues with screenshots like #1378 it might be because YouTube's layout has changed and the area the block button used to go no longer exists.

It would be nice to block channels and videos from the extension pop-up instead so that it isn't tied to YouTube's layout, which changes often.

Browser: Firefox 122
Extension version: 4.615

Screenshot 2024-01-28 at 15-20-32 IGN

@jahed jahed added Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Jan 28, 2024
@ImprovedTube
Copy link
Member

hi @jahed good point!
what about YouTube's blocking feature?

@jahed
Copy link
Author

jahed commented Jan 29, 2024

@ImprovedTube I'm using YouTube without being logged in. I found Improved YouTube to be perfect for this use case since I can remove sidebar recommendations, shorts, headers, change home/trending to search etc. for a minimal distraction-free experience. I was hoping to use the blocking feature too to filter click-bait channels from search results.

@ImprovedTube
Copy link
Member

(hi @Huhni please dont be bothered while these "assignments are based on luck (and history / efficiency maybe).


clickbait

then did you know @jahed https://github.com/MarcGuiselin/youtube-refined? BTW (might lack many updates by now; https://github.com/code-charity/youtube#%EF%B8%8Froadmap )

  • while manually orchestrating one's own queries, like in youtube refined, might requires ambitious users maybe meaningful/universal patters to identify something like clickbait can be constructed for many people at once? compare:
    var musicIdentifiers = /(official|music|lyrics)[ -]video|(cover|studio|radio|album|alternate)[- ]version|soundtrack|unplugged|\bmedley\b|\blo-fi\b|\blofi\b|a(lla)? cappella|feat\.|(piano|guitar|jazz|ukulele|violin|reggae)[- ](version|cover)|karaok|backing[- ]track|instrumental|(sing|play)[- ]?along|卡拉OK|卡拉OK|الكاريوكي|караоке|カラオケ|노래방|bootleg|mashup|Radio edit|Guest (vocals|musician)|(title|opening|closing|bonus|hidden)[ -]track|live acoustic|interlude|featuring|recorded (at|live)/i;
    album|Álbum|专辑|專輯|एलबम|البوم|アルバム|альбом|앨범|mixtape|concert|playlist|\b(live|cd|vinyl|lp|ep|compilation|collection|symphony|suite|medley
    - (there are sources for "clickbait identifiers" and AI could help too)

@jahed
Copy link
Author

jahed commented Jan 30, 2024

To clarify, this isn't a feature request! I just noticed there's a channel blocking feature in this extension, but no way to actually block channels. So I thought I'd report it as a bug. Feel free to close this issue if it's an unsupported/unmaintained feature.

Since ImprovedYouTube is Firefox-recommended and seemed to have that feature too, I thought I could avoid using another extension. There are extensions like BlockTube that block channels and are somewhat maintained so I can use those instead.

@ImprovedTube ImprovedTube added the Feature request Wish or idea label Feb 1, 2024
@ImprovedTube
Copy link
Member

this isn't a feature request

feel free to add one

@ImprovedTube
Copy link
Member

this isn't a feature request

feel free to add one

combined threads can save time +increase motivation @jahed

  • when we fix this we can also fix "play-all"

    4.6.2 PLAY ALL BUTTON
    ------------------------------------------------------------------------------*/
    ImprovedTube.channelPlayAllButton = function () {
    if (this.storage.channel_play_all_button === true) {
    if (/\/@|((channel|user|c)\/)[^/]+\/videos/.test(location.href)) {
    var container = document.querySelector('ytd-channel-sub-menu-renderer #primary-items');

  • Previously they were on channel pages only, but buttons will be appreciated next to our other thumbnail buttons and or context-menu (+notification buttons to come #2009 )

@DarckCrystale
Copy link

Hi, thanks for creating this issue! I have the same usage of ImprovedTube as @jahed 🙂

@ImprovedTube do you have an estimate of when it will be fixed?

@Anoaxx
Copy link

Anoaxx commented Feb 24, 2024

Cool avatar @DarckCrystale B)

@raszpl
Copy link
Contributor

raszpl commented Mar 4, 2024

it-add-to-blocklist added at

var button = document.createElement('button'),

and it works, but the "button" is black on black :) it shows up when you hover over the Thumbnail
locklist

fill: var(--yt-spec-icon-active-other, #fff);

and --yt-spec-icon-active-other is #030303 for me = black icon on black background

add channel to blocklist works and is visible on both white and black background:
blocklist2

@ImprovedTube
Copy link
Member

a youtube update might be causing the missing button on channel pages to @jahed @DarckCrystale, no? @raszpl
and this might be the same reason our play-all button doesn't appear to people (#1971 (comment))

@raszpl
Copy link
Contributor

raszpl commented Mar 6, 2024

might be the same reason our play-all button doesn't appear to people (#1971 (comment))

no, it cant find where to put it

document.querySelector('ytd-channel-sub-menu-renderer #primary-items')
null
document.querySelector('#primary-items')
null
document.querySelector('ytd-channel-sub-menu-renderer')
null

@ImprovedTube
Copy link
Member

no,

(yes,

since play-all also uses:)

ytd-channel-sub-menu-renderer #primary-items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug or required update after YouTube changes Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ YouTube changed
Projects
None yet
Development

No branches or pull requests

6 participants