Subscription page forgets list view #2105
Comments
Shad0wRyu
added
Bug
|
hi @Shad0wRyu, thanks! rolling back to the previous version for today. |
ImprovedTube
changed the title
You rolled back to completely broken version, why?
edit: I looked at wrong thing, rechecking. Old broken version works because its so broken it cant even override f6 properly when saving themes, it either doesnt touch cookies leaving broken theme (most people never used extension theme support so didnt trigger it), or if you change themes couple of times in a row it corrupts the cookie - user sees list setting changed, sets it again in YT and that overrides PREF fixing cookie but leaves broken theme. New build fixed themes and properly overrides f6. Sadly f6 wasnt fully documented anywhere, I even asked what it does before committing the patch :( |
|
It absolutely does work that way. I did turn off the extension and test it. The subscription page settings remained every time. Are you just looking at the subscription feed on the home page?
…-------- Original message --------
From: Rasz_pl ***@***.***>
Date: 3/18/24 9:49 AM (GMT-05:00)
To: code-charity/youtube ***@***.***>
Cc: Shad0wRyu ***@***.***>, Mention ***@***.***>
Subject: Re: [code-charity/youtube] Subscription page forgets list view (Issue #2105)
hi @Shad0wRyu<https://github.com/Shad0wRyu>, thanks! rolling back to the previous version for today.
You rolled back to completely broken version, why?
it crashes at #2058<#2058> and doesnt do anything handled by ytElementsHandler beyond that point.
hi @raszpl<https://github.com/raszpl>! Want to revise your recent commits about cookies?
why?
This a completely bogus bug report, Youtube doesnt do what Shad0wRyu thinks it does. Youtube doesnt save "subscription page arrangement settings". Disable extension and check for yourself.
—
Reply to this email directly, view it on GitHub<#2105 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BHBWVY2S6NFFB7UQ7OWY2GDYY3WGHAVCNFSM6AAAAABE2ZISM2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBTHE3DMMJYGA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
I edited my reply an hour ago after rechecking. Initially I thought you meant channel video feed. |
|
Ah, I didn't see the edit. I'm just getting emails.
…-------- Original message --------
From: Rasz_pl ***@***.***>
Date: 3/18/24 11:08 AM (GMT-05:00)
To: code-charity/youtube ***@***.***>
Cc: Shad0wRyu ***@***.***>, Mention ***@***.***>
Subject: Re: [code-charity/youtube] Subscription page forgets list view (Issue #2105)
It absolutely does work that way. I did turn off the extension and test it. The subscription page settings remained every time. Are you just looking at the subscription feed on the home page?
I edited my reply an hour ago after rechecking. Initially I thought you meant channel video feed.
—
Reply to this email directly, view it on GitHub<#2105 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BHBWVY4O2TJMBNKSABO7B23YY37M7AVCNFSM6AAAAABE2ZISM2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBUGE3DSMRRGQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Sorry, I wrote my initial reply too quickly without verifying thoroughly. |
|
Hey, no worries
…-------- Original message --------
From: Rasz_pl ***@***.***>
Date: 3/18/24 11:52 AM (GMT-05:00)
To: code-charity/youtube ***@***.***>
Cc: Shad0wRyu ***@***.***>, Mention ***@***.***>
Subject: Re: [code-charity/youtube] Subscription page forgets list view (Issue #2105)
Sorry, I wrote my initial reply too quickly without verifying thoroughly.
—
Reply to this email directly, view it on GitHub<#2105 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BHBWVY426OCQQWVZM3QI27DYY4ET5AVCNFSM6AAAAABE2ZISM2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBUGI4TKOBRGE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
👍👍 @raszpl
it can be done in a minute (simple trade-off since old bugs don't cause new confusion like new bugs,
👍 so hideDetailButton() doesn't run i shouldn't have missed this in 2023. The fix is in included in the store version (v4.805)
really? It should only break those ytElementsHandler() function calls leading to call hideDetailButton() |
I understant reverting on main extension. I think I asked about it already long time ago - isnt that what https://chromewebstore.google.com/detail/improve-youtube-%F0%9F%8E%A7-for-yo/lodjfjlkodalimdjgncejhkadjhacgki is for? I even asked why didnt you rename it to [Testing] or [Staging].
you are probably right, but "Themes are broken, autoplay is broken, "default channel tab" is broken." are still true for version currently in store |
did you fix autoplay?
yes can, run slow tests with the testing version. (Also updating both at once, the main version usually takes some more hours/days to be reviewed, while the test might passes immediately, so if a bug was noticed in testing already, we might canceled the review for the main version (while rolling back will take another review cycle at ChromeWebStore, unlike Firefox) |
its not "broken" broken, you added code breaking it deliberately with dc00a7e "fixes & tidy" #2042 (comment) |
Bug Report:
⚬ BUG: Videos on subscription page change arrangement settings after refresh
⚬ HOW: On Opera GX, ImprovedTube version 4.780, going to the subscription page and arranging videos by list. Refresh the page twice and they default back to grid pattern
⚬ If a YouTube change started the bug, please copy the DOM you get (especially if the bug doesn't happen when you log out or on another computer)
⚬ Or did our last update start the bug? Only started after latest ImprovedTube update
⚬ ImprovedTube Version: 4.780
1. Thanks for coming & caring! Before submitting, please check if the issue has already been reported ever. With GitHub's issue search (use this link) (else removing "is:issue is:open" from the standard search) ( - If it was posted before, you can answer/react there to give it your voice and move it up in the lists) ( - If the status is "closed" (=fixed) recently, then Web Stores can be updated soon - if it was closed month or years ago, then it might reappeared & must be fixed again.)
2. To give us a chance to solve the bug: Can you ...?:
(FireFox:) 
- ..deactivate other extensions running on YouTube? (or use an incognito window after activating this extension to run there / chrome://extensions
detailschrome://extensions/?id=bnomihfieiccainjcjblhegjgglakjdd )- ..open the Browser-console, with the
F12-Key, before/when the error occures? (then hopefully you'll see an error message in the console).- ...copy the YouTube-DOM shown above the console (
F12) in case YouTube is giving you a new verson. You can copying the root element<html>in the top after the bug happened:- There are 2-3 different versions depending if you open a new window or clicked a link on youtube
More / optionally:
⚬ Screenshots:
/ ⚬ Context:
/ ⚬ Expected /preferred behavior:
⚬ Browser: Chromium version:121.0.6167.186
⚬ Settings:
⚬ OS: Windows 11
⚬ Device:
The text was updated successfully, but these errors were encountered: