Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Add to Blocklist" button no longer working in Nightly (129.0a1 (2024-06-28) (64-bit)) #2422

Open
Eyevou opened this issue Jun 29, 2024 · 7 comments
Labels
Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@Eyevou
Copy link

Eyevou commented Jun 29, 2024

I just attempted to block a channel and the button did not function at all.

@Eyevou Eyevou added Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Jun 29, 2024
@Eyevou Eyevou changed the title "Add to Blacklist" button no longer working in Nightly (129.0a1 (2024-06-28) (64-bit)) "Add to Blocklist" button no longer working in Nightly (129.0a1 (2024-06-28) (64-bit)) Jun 29, 2024
@ImprovedTube
Copy link
Member

hi! @Eyevou

sad, can you tell more? v4.1007?
i think @raszpl worked hard on this recently.

@Eyevou
Copy link
Author

Eyevou commented Jul 1, 2024

can you tell more? v4.1007?
Yep, 4.1007.

https://www.youtube.com/watch?v=sWNqknrPhl4

This is what happens when attempting to blocklist a channel.

Blocklisting a specific video works fine. It's just the channel block that doesn't appear to function.

@raszpl
Copy link
Contributor

raszpl commented Jul 1, 2024

browser? does it say "blocklist click: no channel ID or metadata" in console?
Edit: oh the pain, YT is serving three different versions of HTML. Back to 'YTD-SUBSCRIBE-BUTTON-RENDERER', 'YT-SUBSCRIBE-BUTTON-VIEW-MODEL', 'ytd-button-renderer.ytd-c4-tabbed-header-renderer'
-one is FF exclusive, in FF button doesnt how at all :|
-on one of chrome versions metadata is missing
fixed #2428

@Eyevou
Copy link
Author

Eyevou commented Jul 1, 2024

browser?

Firefox Nightly.

does it say "blocklist click: no channel ID or metadata" in console?

Yes:

blocklist click: no channel ID or metadata blocklist.js:127:12
onclick moz-extension://26289df2-3403-4e3e-a948-75d66d48b4f8/js&css/web-accessible/www.youtube.com/blocklist.js:127

@raszpl
Copy link
Contributor

raszpl commented Jul 1, 2024

Firefox Nightly.

hah, so you get chrome html version in FF, or maybe its not chrome but not logged in one, YT is so weird :|

does it say "blocklist click: no channel ID or metadata" in console?

Yes:

should be fixed after this patch

@Eyevou
Copy link
Author

Eyevou commented Jul 1, 2024

should be fixed after this patch

When the changes get posted to the repo I'll be sure to test it and see. Thanks!

ImprovedTube added a commit that referenced this issue Jul 3, 2024
Update blocklist.js cover three currently known versions of HTML #2422
@Gitoffthelawn
Copy link

Gitoffthelawn commented Jul 31, 2024

Just FYI, the button to Add to Blocklist for channels is not appearing for me (on channel pages) in v4.1085 with Firefox 128.0.3.

I do have blocklist functionality enabled in the extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
None yet
Development

No branches or pull requests

4 participants