-
-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raszpl patch 2 #1671
Raszpl patch 2 #1671
Conversation
typo in comment, missing semicolon, spaces to tabs
alignment, spaces to tabs
more code alignment
'up next autoplay' moved next to autoplay, quality moved next to codec options
added helper modal function, "Codec h.264" sets "Codecs", "Codecs" disable "Codec h.264"
Improved modal dialog handling, clicking outside tries to Cancel, previously clicking outside just force removed dialog.
fixing previous commit duplicate lines
removing "block_vp8", YT doesnt use it anymore. "Codecs" works now, can pick individual codecs to block.
removed block_vp8
more work on ModalHelper, popup warnings for disabling all video decoders.
more h264/codec interaction work, now switching one automatically updates another. Preliminary optimize_codec_for_hardware_acceleration implementation. Needs a list of GPUs with supported hardware codecs.
Few strings like 'Optimize Codec for hardware acceleration' 'You need either VP9 or H264 enabled for Youtube to work. Disabling both will break Video.' will need localization. |
… one instead of highest
hey, thanks!!😮😮😮 regret to be late!
tried to say in #1211 "2."
|
*didnt see all at first! 🤩 thanks! |
Afaik VP8 no longer exist on YT, that is YT doesnt server any VP8 content anymore. Every time a page loads YT queries browser for its codec capabilities, you can
in every breakpoint look at mime variable, it will contain codec String Youtube is testing. Afaik it will be around 20 tests, different codecs and capabilities (50/60fps etc). Im not sure if its different depending on video sources available. This will give you an idea of what YT uses. |
Codecs were listed from oldest to newest. That is the usual convention. |
Hi 🤩 please keep it up 😀 your methods are advanced. Somebody should make them wikipages.
also wondered to remember something so all-together, its just 2 options , for YouTube
( so it could be just a 3-way-switch, ) (or keeping all switches just in case we are missing a relevant reason to block all, just probably we aren't.) |
UI:
"most common first" is efficent /more useful to people who hurry or dont know much yet & might just try whats good
yes, we can make it / change it 👍 (+one could claim breaking standards can be worth it, if users need focus/not click mindlessly, but anti-UX might rarely really make sense) Seems a bit hard to define the standard: Also our toggles, are on right visually, like mobile Apps, unlike most extensions, I think all at once wouldnt harm: a check at the right and left & the whole item also reacting like a big key, shrinking in size when active (pressed in) (=less scrolling!) (- and getting a slight shadow, or slight lightning or partical lightning certain mechanical) |
Greetings! @raszpl |
'up next autoplay' moved next to autoplay, quality moved next to codec options
added helper modal function, "Codec h.264" sets "Codecs", "Codecs" disable "Codec h.264"
Improved modal dialog handling, clicking outside tries to Cancel, previously clicking outside just force removed dialog.
removing "block_vp8", YT doesnt use it anymore. "Codecs" works now, can pick individual codecs to block.
more work on ModalHelper, popup warnings for disabling all video decoders.
more h264/codec interaction work, now switching one automatically updates another.