Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

black background color #1843

Draft
wants to merge 1,475 commits into
base: master
Choose a base branch
from
Draft

Conversation

anshuman-rai-27
Copy link

@anshuman-rai-27 anshuman-rai-27 commented Nov 18, 2023

black background by default from Youtube setted #1773 #1783

raszpl and others added 30 commits May 17, 2023 04:11
player_quality reflects 1080p resolution limit when player_h264 is enabled
use id to directly switch linked options instead of relying on  previousSibling/nextSibling
moved repeating code in player_codecs into common function
player_quality now clearly shows Video wont work when codecs are disabled.
Better handling for clicking outside modal.confirm, try cancel() first.
Explanation comment for reason behind "values as functions isFunction(value)"
code-charity/SATUS#7 passing key instead of object
make analyzer show up in 'My active features' code-charity/SATUS#8
fix for "After installation, h.264 needs to be clicked twice before it reacts and the modal appears"
code-charity#1681
slightly clearer messaging about disabled vital codecs
updating codecs to currently used by YT
@ImprovedTube
Copy link
Member

ImprovedTube commented Nov 18, 2023

thank you! @anshuman-rai-27

--satus-light: 0, 20, 82;
--satus-light: 255, 255, 255;

can you show / explain what you did?
i didn't write satus.css, but it is about our UI (the extension settings popup)
compare: f476b4f

also answered in #1773

@ImprovedTube ImprovedTube added the No entiendo🥺 Seems we didnt understand some part. (Not enough information or unclear wording? Or out of scope?) label Nov 18, 2023
@ImprovedTube ImprovedTube force-pushed the master branch 2 times, most recently from 439656f to 257db41 Compare November 23, 2023 01:35
@ImprovedTube
Copy link
Member

ping @anshuman-rai-27

@ImprovedTube ImprovedTube force-pushed the master branch 2 times, most recently from 4dd983d to df2cac1 Compare November 28, 2023 03:43
@anshuman-rai-27
Copy link
Author

i have just changed the default background color to dark by giving it color value which is of dark mode and also the color of the text and search box changed accordingly

@ImprovedTube
Copy link
Member

thanks! @anshuman-rai-27 did this improve or fix something in our popup? ( #1773 seems to be about youtube.com )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No entiendo🥺 Seems we didnt understand some part. (Not enough information or unclear wording? Or out of scope?)
Projects
None yet
Development

Successfully merging this pull request may close these issues.