-
-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow ads for small creators #1970
Allow ads for small creators #1970
Conversation
there is a bug when you are in small creators option and close and open extension tab the count component is still hidden
by setting the value of display of count using the count component it self not the ad component
@ImprovedTube kindly review this code |
amaazing!! thanks! |
Thank you for the opportunity to contribute to this awesome project! |
please repeat one day! 😳 @josephShokry ( The input /style can be streamlined with our other inputs, such at appearance:player:size:custom (both could share the same css class. And Player:fixed volume (should a have a a faint frame or cursor. It also had a fine tuneing button before, just disappeared in a satus update somehow )) ( Also, hopefully we have optional compensation available at OpenCollective or so sooner than later. ) 👋 |
@ImprovedTube No problem I can continue contributing on this issue but kindly explain what is the problem as I don't understand |
@ImprovedTube any updates?? |
hi @josephShokry! sorry to read this late
no problem! just meant, since we have a few more html <input>'s already, we might use similar style or the same class. |
Implements #1958
I have added the option in the Ads section to allow users to choose if they want to Allow Ads for small creators and if they choose this option they will specify the number of subscribers that define the small creators (this option is hidden if the user chooses any other type of Ads like On or Off).