Disable Video Preview On Hover Option #2007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The setting would require a reload in order to work because the name "disable_thumbnail_playback" was different than disableHoverVideo. Everything is now "disableThumbnailPlayback" and seems to work.
ugackMiner53
changed the title
|
Tysm for caring! @ugackMiner53 |
|
..then maybe💭you even have an idea how we could fix our buttons on thumbnails in youtube's feeds. (they are blocklist, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to disable video playback when hovering over thumbnails on the home page.
(Fixes #1785)
How it works:
Instead of using D-Rekk's solutions of
getEventListeners(node)orelem.remove(), this solution adds an event listener to the global window object, listening for globalmouseenterevents.Then, if the event's
composedPathproperty contains an element matching "#content dtd-rich-item-renderer" (which selects the thumbnail elements that listen for the mouseenter event), the event is immediately stopped withevent.stopImmediatePropagation();.The event also runs before YouTube's native events by telling the event listener to trigger during the capturing phase instead of the bubbling phase.
Notes:
The second part of the issue (for recommended video previews in the sidebar) should already be covered by the "Hide animated thumbnails" option.
This is my first commit to the codebase, so please let me know if there are any changes that need to be made to integrate it!