Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleaning up empty files #2072

Merged
merged 4 commits into from
Mar 7, 2024
Merged

cleaning up empty files #2072

merged 4 commits into from
Mar 7, 2024

Conversation

raszpl
Copy link
Contributor

@raszpl raszpl commented Mar 5, 2024

Removing empty files.

@raszpl raszpl changed the title Lessfiles cleaning up empty files Mar 5, 2024
@ImprovedTube
Copy link
Member

hi! @raszpl glad you are back!

btw the youtube.com folder were once added planning for global video features on all sites.
and we can further reconsider the amount of files and defined/document reasons to use content-scripts vs. web-accessible to avoid confusion

5d05160

@raszpl
Copy link
Contributor Author

raszpl commented Mar 6, 2024

this patch only removes empty files, there is nothing in them except comments

/*--------------------------------------------------------------
>>> PLAYER
----------------------------------------------------------------
#
--------------------------------------------------------------*/

@ImprovedTube
Copy link
Member

hi! @raszpl glad you are back!

btw the youtube.com folder were once added planning for global video features on all sites.
and we can further reconsider the amount of files and defined/document reasons to use content-scripts vs. web-accessible to avoid confusion

5d05160

this patch only removes empty files

yes, just assumed this was after looking at our:

undocumented directory structure:

  • this pending feature was placed in the deleted file 5d05160

  • the other two .js files in "appearance" also are very short.

  • we can reconsider what is web-accessible and what is content script.

  • ...

@ImprovedTube ImprovedTube added the Knowledge Base / Dokumenation for developers We should repurpose this for future reference / Wiki / Education / Introduction label Mar 7, 2024
@ImprovedTube ImprovedTube merged commit 5b3d7ce into code-charity:master Mar 7, 2024
@raszpl raszpl deleted the lessfiles branch March 10, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Knowledge Base / Dokumenation for developers We should repurpose this for future reference / Wiki / Education / Introduction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants