Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Full Hebrew locale support #2586

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

jackSeigerman
Copy link
Contributor

I took the English locale file and I went through it one by one and translated to Hebrew, I'm not fully fluent, but used some external sources for some words like "application" and such. If I made any mistakes please let me know!

I took the English locale file and I went through it one by one and translated to Hebrew, I'm not fully fluent, but used some external sources for some words like "application" and such. If I made any mistakes please let me know!
@ImprovedTube
Copy link
Member

ImprovedTube commented Sep 25, 2024

hi @jackSeigerman! wow, thanks!

Youtube doesn't translate the word (name) "Shorts", so that we need not either or at most in ( parenthesis ) ? & the name ImprovedTube need not be translated, unless we translate it everyhwere in our store listings, title, description and website too.

tools

which?

Translation


If I made any mistakes please let me know!

We could add notes & links like this in the extension nicely (or every time somebody sets a specific language.)

However yet we auto select the languages too yet ( #2484 )
And we run on a single repo branch for efficiency. Everything merged will also go live for everyone,
(So assumably you still want to revise before merging?)

You can also mention each one that you weren't sure about for the next person to check and take them out of the file, so it will show the English ones instead and be more likely that later somebody joins us here in this thread to help with revision.

(or mark tricky ones up in the hebrew version somehow, if you like, For example keeping the english one with the translation in parenthesis)

@Dorshir

@jackSeigerman
Copy link
Contributor Author

yeah, understood. for the "tools" I used a combination of google translate, morphix (another translation website) I basically ran the translation in both and took the one that seemed more correct. As for the shorts term, I just went to youtube.co.il and copied the word for shorts, I can change both this and any mention to the word "tube" or "Improvedtube" back to English, or transliterate, which I believe I already did for some words, like "chrome" and such. I can go back and comment above any of the translations I was not 100% on, as for the merge and branch thing you said: I must admit, I never actually contributed to a public Github repo before this one, So I never had to deal with pull requesting and such. Did I do something wrong or rather would it be better if I pushed some other way, I'm not really sure I've only worked on small teams and personal projects. Either way Please let me know, but I'm glad to be of any help.

@ImprovedTube
Copy link
Member

hebrew

I can go back and comment above any of the translations I was not 100%

Sounds good ! (i thought of this thread since JSON doesnt know comments)

we run on a single repo branch for efficiency. Everything merged will also go live

just meant, sorry if i sound "perfectionist", while other projects with many users might have an intermediary stage between merging and publishing (unlike us)

@decimaldreamer
Copy link
Contributor

Looking good.

@ImprovedTube
Copy link
Member

*Would you mind to review (some of) this @Dorshir?

@Dorshir
Copy link
Contributor

Dorshir commented Oct 1, 2024

*Would you mind to review (some of) this @Dorshir?

Sure, I did review some, looks good and indeed correct translations. Note that i didnt go through the entire document, just picked around 100 random samples. :)

@ImprovedTube
Copy link
Member

Thanks! @Dorshir, so i just undid the translations of Shorts and ImprovedTube for now.
Afaik (screenshot above) YouTube doesn't translate "Shorts" including the homepage in Hebrew.

Merging proactively.
Looking forward @jackSeigerman for your final revision or any other contributions.

@ImprovedTube ImprovedTube merged commit 784b52b into code-charity:master Oct 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants