Skip to content

Conversation

michaeltmiller
Copy link
Contributor

closes #342

@michaeltmiller michaeltmiller requested a review from miorel as a code owner August 20, 2024 04:02
@miorel miorel requested review from simona1 and elimanzo August 20, 2024 05:00
@miorel
Copy link
Contributor

miorel commented Aug 20, 2024

To fix the checks you will need to run yarn package-goodies:test -u in the workspaces/adventure-pack directory. I broke the extraction code at least once before, so this validates that all the goodies can be successfully extracted. It also highlights when changes to the extraction code do or don't impact the resulting goodies output.

Copy link
Contributor

@simona1 simona1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for working on it, Michael.

Copy link
Contributor

@elimanzo elimanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @michaeltmiller thanks for this PR 💯. I learned a lot about how groupBy works . It reminds me a lot like working with tries, and how we group up prefixes 👍🏽

@miorel miorel changed the title Add Typescript Map.groupBy goody Add TypeScript Map.groupBy goody Aug 20, 2024
@miorel
Copy link
Contributor

miorel commented Aug 22, 2024

Thanks for working on it!

@miorel miorel merged commit 2ebdf9a into code-chronicles-code:main Aug 22, 2024
@michaeltmiller michaeltmiller deleted the ts_map_groupby_goody branch August 23, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Map.groupBy TypeScript goody
4 participants