-
Notifications
You must be signed in to change notification settings - Fork 13
Add TypeScript Map.groupBy
goody
#358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TypeScript Map.groupBy
goody
#358
Conversation
To fix the checks you will need to run |
workspaces/adventure-pack/goodies/typescript/Map.groupBy/index.test.ts
Outdated
Show resolved
Hide resolved
workspaces/adventure-pack/goodies/typescript/Map.groupBy/index.test.ts
Outdated
Show resolved
Hide resolved
workspaces/adventure-pack/goodies/typescript/Map.groupBy/index.test.ts
Outdated
Show resolved
Hide resolved
workspaces/adventure-pack/goodies/typescript/Map.groupBy/index.ts
Outdated
Show resolved
Hide resolved
workspaces/adventure-pack/goodies/typescript/Map.groupBy/index.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you for working on it, Michael.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @michaeltmiller thanks for this PR 💯. I learned a lot about how groupBy
works . It reminds me a lot like working with tries, and how we group up prefixes 👍🏽
Map.groupBy
goody
workspaces/adventure-pack/goodies/typescript/Map.groupBy/index.ts
Outdated
Show resolved
Hide resolved
workspaces/adventure-pack/goodies/typescript/Map.groupBy/index.test.ts
Outdated
Show resolved
Hide resolved
workspaces/adventure-pack/goodies/typescript/Map.groupBy/index.test.ts
Outdated
Show resolved
Hide resolved
workspaces/adventure-pack/goodies/typescript/Map.groupBy/index.test.ts
Outdated
Show resolved
Hide resolved
Thanks for working on it! |
closes #342