Skip to content

Add traversePostOrderNAry TypeScript goody #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Add traversePostOrderNAry TypeScript goody #388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions workspaces/adventure-pack/goodies/typescript/traverseInOrder/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,18 @@ export function* traverseInOrder<
T extends { left?: T | null | undefined; right?: T | null | undefined },
>(root: T | null | undefined): Generator<T, void, void> {
const stack: [T | null | undefined, boolean][] = [[root, false]];
while (stack.length > 0) {

do {
const [node, didTraverseLeftChild] = stack.pop()!;
if (node) {
if (didTraverseLeftChild) {
yield node;
} else {
stack.push([node.right, false], [node, true], [node.left, false]);
}
if (node == null) {
continue;
}
}

if (didTraverseLeftChild) {
yield node;
continue;
}

stack.push([node.right, false], [node, true], [node.left, false]);
} while (stack.length > 0);
}
3 changes: 2 additions & 1 deletion workspaces/adventure-pack/goodies/typescript/traverseLevelOrder/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,14 @@ import { isNonNullish } from "../isNonNullish";
export function* traverseLevelOrder<
T extends { left?: T | null | undefined; right?: T | null | undefined },
>(root: T | null | undefined): Generator<T[], void, void> {
if (!root) {
if (root == null) {
return;
}

let level = [root];
do {
yield level;

level = level
.flatMap((node) => [node.left, node.right])
.filter(isNonNullish);
Expand Down
20 changes: 12 additions & 8 deletions workspaces/adventure-pack/goodies/typescript/traversePostOrder/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,18 @@ export function* traversePostOrder<
T extends { left?: T | null | undefined; right?: T | null | undefined },
>(root: T | null | undefined): Generator<T, void, void> {
const stack: [T | null | undefined, boolean][] = [[root, false]];
while (stack.length > 0) {

do {
const [node, didTraverseChildren] = stack.pop()!;
if (node) {
if (didTraverseChildren) {
yield node;
} else {
stack.push([node, true], [node.right, false], [node.left, false]);
}
if (node == null) {
continue;
}
}

if (didTraverseChildren) {
yield node;
continue;
}

stack.push([node, true], [node.right, false], [node.left, false]);
} while (stack.length > 0);
}
23 changes: 23 additions & 0 deletions workspaces/adventure-pack/goodies/typescript/traversePostOrderNAry/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
export function* traversePostOrderNAry<T extends { children: T[] }>(
root: T | null | undefined,
): Generator<T, void, void> {
const stack: [T | null | undefined, boolean][] = [[root, false]];

do {
const [node, didTraverseChildren] = stack.pop()!;
if (node == null) {
continue;
}

if (didTraverseChildren) {
yield node;
continue;
}

stack.push([node, true]);
// TODO: add an Array.prototype.valuesReversed() goody and use it here
for (let i = node.children.length - 1; i >= 0; --i) {
stack.push([node.children[i], false]);
}
} while (stack.length > 0);
}
8 changes: 5 additions & 3 deletions workspaces/adventure-pack/goodies/typescript/traversePreOrder/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,13 @@ export function* traversePreOrder<
T extends { left?: T | null | undefined; right?: T | null | undefined },
>(root: T | null | undefined): Generator<T, void, void> {
const stack = [root];
while (stack.length > 0) {

do {
const node = stack.pop();
if (node) {

if (node != null) {
yield node;
stack.push(node.right, node.left);
}
}
} while (stack.length > 0);
}
164 changes: 124 additions & 40 deletions workspaces/adventure-pack/src/app/__tests__/__snapshots__/equip-test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2482,16 +2482,20 @@ exports[`App can equip single goody: JavaScript traverseInOrder 1`] = `

function* traverseInOrder(root) {
const stack = [[root, false]];
while (stack.length > 0) {

do {
const [node, didTraverseLeftChild] = stack.pop();
if (node) {
if (didTraverseLeftChild) {
yield node;
} else {
stack.push([node.right, false], [node, true], [node.left, false]);
}
if (node == null) {
continue;
}
}

if (didTraverseLeftChild) {
yield node;
continue;
}

stack.push([node.right, false], [node, true], [node.left, false]);
} while (stack.length > 0);
}

/////////////////////////// END ADVENTURE PACK CODE ////////////////////////////"
Expand All @@ -2507,13 +2511,14 @@ function isNonNullish(value) {
}

function* traverseLevelOrder(root) {
if (!root) {
if (root == null) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question why the preference from !root vs root == null Is this to be more specific since !variable checks for any falsy values?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've gone back and forth on this one. == null is more explicit, !root is more concise... Either one could be something to optimize for in library code. Today I'm feeling more explicit 😄

return;
}

let level = [root];
do {
yield level;

level = level
.flatMap((node) => [node.left, node.right])
.filter(isNonNullish);
Expand All @@ -2530,16 +2535,50 @@ exports[`App can equip single goody: JavaScript traversePostOrder 1`] = `

function* traversePostOrder(root) {
const stack = [[root, false]];
while (stack.length > 0) {

do {
const [node, didTraverseChildren] = stack.pop();
if (node) {
if (didTraverseChildren) {
yield node;
} else {
stack.push([node, true], [node.right, false], [node.left, false]);
}
if (node == null) {
continue;
}
}

if (didTraverseChildren) {
yield node;
continue;
}

stack.push([node, true], [node.right, false], [node.left, false]);
} while (stack.length > 0);
}

/////////////////////////// END ADVENTURE PACK CODE ////////////////////////////"
`;

exports[`App can equip single goody: JavaScript traversePostOrderNAry 1`] = `
"////////////////////////// BEGIN ADVENTURE PACK CODE ///////////////////////////
// Adventure Pack commit fake-commit-hash
// Running at: https://example.com/

function* traversePostOrderNAry(root) {
const stack = [[root, false]];

do {
const [node, didTraverseChildren] = stack.pop();
if (node == null) {
continue;
}

if (didTraverseChildren) {
yield node;
continue;
}

stack.push([node, true]);
// TODO: add an Array.prototype.valuesReversed() goody and use it here
for (let i = node.children.length - 1; i >= 0; --i) {
stack.push([node.children[i], false]);
}
} while (stack.length > 0);
}

/////////////////////////// END ADVENTURE PACK CODE ////////////////////////////"
Expand All @@ -2552,13 +2591,15 @@ exports[`App can equip single goody: JavaScript traversePreOrder 1`] = `

function* traversePreOrder(root) {
const stack = [root];
while (stack.length > 0) {

do {
const node = stack.pop();
if (node) {

if (node != null) {
yield node;
stack.push(node.right, node.left);
}
}
} while (stack.length > 0);
}

/////////////////////////// END ADVENTURE PACK CODE ////////////////////////////"
Expand Down Expand Up @@ -4967,16 +5008,20 @@ function* traverseInOrder<
T extends { left?: T | null | undefined; right?: T | null | undefined },
>(root: T | null | undefined): Generator<T, void, void> {
const stack: [T | null | undefined, boolean][] = [[root, false]];
while (stack.length > 0) {

do {
const [node, didTraverseLeftChild] = stack.pop()!;
if (node) {
if (didTraverseLeftChild) {
yield node;
} else {
stack.push([node.right, false], [node, true], [node.left, false]);
}
if (node == null) {
continue;
}
}

if (didTraverseLeftChild) {
yield node;
continue;
}

stack.push([node.right, false], [node, true], [node.left, false]);
} while (stack.length > 0);
}

/////////////////////////// END ADVENTURE PACK CODE ////////////////////////////"
Expand All @@ -4994,13 +5039,14 @@ function isNonNullish<T>(value: T | null | undefined): value is T {
function* traverseLevelOrder<
T extends { left?: T | null | undefined; right?: T | null | undefined },
>(root: T | null | undefined): Generator<T[], void, void> {
if (!root) {
if (root == null) {
return;
}

let level = [root];
do {
yield level;

level = level
.flatMap((node) => [node.left, node.right])
.filter(isNonNullish);
Expand All @@ -5019,16 +5065,52 @@ function* traversePostOrder<
T extends { left?: T | null | undefined; right?: T | null | undefined },
>(root: T | null | undefined): Generator<T, void, void> {
const stack: [T | null | undefined, boolean][] = [[root, false]];
while (stack.length > 0) {

do {
const [node, didTraverseChildren] = stack.pop()!;
if (node) {
if (didTraverseChildren) {
yield node;
} else {
stack.push([node, true], [node.right, false], [node.left, false]);
}
if (node == null) {
continue;
}
}

if (didTraverseChildren) {
yield node;
continue;
}

stack.push([node, true], [node.right, false], [node.left, false]);
} while (stack.length > 0);
}

/////////////////////////// END ADVENTURE PACK CODE ////////////////////////////"
`;

exports[`App can equip single goody: TypeScript traversePostOrderNAry 1`] = `
"////////////////////////// BEGIN ADVENTURE PACK CODE ///////////////////////////
// Adventure Pack commit fake-commit-hash
// Running at: https://example.com/

function* traversePostOrderNAry<T extends { children: T[] }>(
root: T | null | undefined,
): Generator<T, void, void> {
const stack: [T | null | undefined, boolean][] = [[root, false]];

do {
const [node, didTraverseChildren] = stack.pop()!;
if (node == null) {
continue;
}

if (didTraverseChildren) {
yield node;
continue;
}

stack.push([node, true]);
// TODO: add an Array.prototype.valuesReversed() goody and use it here
for (let i = node.children.length - 1; i >= 0; --i) {
stack.push([node.children[i], false]);
}
} while (stack.length > 0);
}

/////////////////////////// END ADVENTURE PACK CODE ////////////////////////////"
Expand All @@ -5043,13 +5125,15 @@ function* traversePreOrder<
T extends { left?: T | null | undefined; right?: T | null | undefined },
>(root: T | null | undefined): Generator<T, void, void> {
const stack = [root];
while (stack.length > 0) {

do {
const node = stack.pop();
if (node) {

if (node != null) {
yield node;
stack.push(node.right, node.left);
}
}
} while (stack.length > 0);
}

/////////////////////////// END ADVENTURE PACK CODE ////////////////////////////"
Expand Down
Loading