Skip to content

Use a webpack plugin to generate Adventure Pack index.html #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 31, 2024
Merged

Use a webpack plugin to generate Adventure Pack index.html #487

merged 2 commits into from
Oct 31, 2024

Conversation

miorel
Copy link
Contributor

@miorel miorel commented Oct 29, 2024 •
edited
Loading

This allows the file to be written when we run webpack in watch mode.

@miorel miorel requested review from simona1 and elimanzo October 29, 2024 05:25
@miorel miorel force-pushed the webpack-index-html branch from 2bf0d8b to 81e7cdc Compare October 29, 2024 05:37
elimanzo
elimanzo approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@elimanzo elimanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@miorel miorel merged commit 3d69c98 into main Oct 31, 2024
9 checks passed
@miorel miorel deleted the webpack-index-html branch October 31, 2024 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elimanzo elimanzo elimanzo approved these changes

@simona1 simona1 Awaiting requested review from simona1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miorel @elimanzo