Type 'string' is not assignable to type 'Level'

[vcorr]

I get this error for at least the version 0.2.3. I can't yet update to 0.3.0.

Line: /angular2-logger/app/core/logger.ts:59:38

Related to this? https://basarat.gitbooks.io/typescript/content/docs/tips/stringEnums.html

changing the line 59 from:
private _loadLevel = (): Level => localStorage.getItem( this._storeAs );
to
private _loadLevel = (): Level => +localStorage.getItem( this._storeAs );

Seems to fix it (converts string to number)

[langley-agm]

Hello @vcorr ,

Could you share your Typescript compiler version and your tsconfig options?

[vcorr]

absolutely,

"typescript": "1.9.0-dev.20160503",

"compilerOptions": {

"target": "ES5",
"module": "commonjs",
"emitDecoratorMetadata": true,
"experimentalDecorators": true,
"moduleResolution" : "node",
"sourceMap": true

},

[langley-agm]

@vcorr I was able to reproduce your issue when I use typescript 1.9.0-dev.20160503, however that's not an official release yet.

I ran some tests and this issue is not happening with the latest official release: 1.8.10. I suggest you to use that instead.

However, I will leave this issue open in case it continues to occur after they officially release the next version, thank you !

[k7sleeper]

I run into the same issue with tsc v1.9.0-dev.20160601-1.0. I'm bound in using it because I need the path mapping features in conjunction with JSPM :-(

Is it an error of the TypeScript compiler?

[langley-agm]

@k7sleeper To clarify:

It's an error thrown by the Typescript compiler. Not precisely an error of the compiler. The error is in the logger's code if the following official version of Typescript ships the way it is now ( in 1.9.0-dev ). If it does, it will get fixed appropriately.

[k7sleeper]

OK, I understand.Tx.

I wonder why the compiler reads ./app/core/logger.ts although ./app/core/logger.d.ts is present and sufficient for defining the API of a 3rd party library.

[k7sleeper]

If I add a "typings": "core.d.ts",to package.json and remove app/core/*.ts then there's no compiler error.

[langley-agm]

@k7sleeper core.d.ts gets generated by the compiler out of core.ts if the .d.ts is present is only because it has already been compiled.

[k7sleeper]

That's clear!

Setting the typings attribute in package.json to core.d.ts let's the TypeScript compiler use core.d.ts when compiling import {Logger} from "angular2-logger";. That's what's needed to avoid compiling whole angular2-logger sources. Angular2 folks do the same. They set the typings attribute in package.json.

[langley-agm]

@k7sleeper sorry, miss-clicked the close button.

let's the TypeScript compiler use core.d.ts

The typescript compiler doesn't use .d.ts files, it generates them. If you wanted to compile .d.ts files you'd have to write them yourself, or compile once to generate the .d.ts files and a second config that compiles those into js. However, .d.ts files are merely the definitions of the API, you'd be compiling empty definitions with no implementation whatsoever, you'd be able to call the functions but they wouldn't be doing anything.

Also package.json doesn't tell the compiler how to compile, that's tsconfig.json.

Just clarifying some things to avoid miss-conceptions. I'll be carefully reviewing your pull requests with more calm as soon as I get a chance.

Thanks for contributing !

[k7sleeper]

The typescript compiler doesn't use .d.ts files, it generates them.

No, it also uses them for getting type information when processing import statements if no .ts file exists which is normally the case if you import a 3rd party library (i.e. angular2-logger).

Also package.json doesn't tell the compiler how to compile, that's tsconfig.json.

No!

The typings attribute of package.json tells the compiler which type definition file (.d.ts) should be used if the client code imports the package (i.e. import {Logger} from "angular2-logger").

The main attribute of package.json tells the loader (i.e. SystemJS) which JavaScript file should be loaded if the client code imports the package (i.e. import {Logger} from "angular2-logger").