Export subclass of Ember.Service, run loops #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanmatiasko
changed the title
| resolve(response); | ||
|
|
||
| Ember.run.end(); | ||
| Ember.run(null, response.error ? reject : resolve, response); |
There was a problem hiding this comment.
please don't use ternary operators, they make code less clear
|
Thanks for sending this over, if you get rid of the ternary operators I'll merge this in. |
|
Thanks for feedback, they have been removed. |
buritica
added a commit
that referenced
this pull request
Jul 19, 2015
buritica
added a commit
that referenced
this pull request
Jul 19, 2015
|
hey @romanmatiasko thanks for your contribution, since the run loop optimization breaks the addon, I've gone ahead and separated the service update into #18 and will be closing this in favor of it. |
buritica
added a commit
that referenced
this pull request
Jul 19, 2015
[improve] export service as suggested by #18
buritica
added a commit
that referenced
this pull request
Jul 19, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ember 1.13.0-beta.2 expects service to be a subclass of Ember.Service.
Uncaught Error: Assertion Failed: Expected service:stripe to resolve to an Ember.Service but instead it was (unknown mixin).See also emberjs/ember.js#11292.
There is only deprecation instead of assert in Ember Canary, but this is definitely more future-proof.
Also, simplified run loops as mentioned in #17.