Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Javalab - Add light mode theme and theme toggle #39964

Merged
merged 11 commits into from
Apr 14, 2021
Merged

Javalab - Add light mode theme and theme toggle #39964

merged 11 commits into from
Apr 14, 2021

Conversation

JillianK
Copy link
Contributor

@JillianK JillianK commented Apr 7, 2021

Added a light mode theme and the ability to toggle between light and dark modes. Final designs are still TBD

dark.mode.light.mode.toggle.mov

Links

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@JillianK JillianK requested review from molly-moen and jmkulwik April 7, 2021 23:10
molly-moen
molly-moen reviewed Apr 7, 2021
View reviewed changes
Copy link
Contributor

@molly-moen molly-moen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great!

molly-moen
molly-moen approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@molly-moen molly-moen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jmkulwik
jmkulwik reviewed Apr 8, 2021
View reviewed changes
apps/test/unit/javalab/JavalabViewTest.js
} from '@cdo/apps/redux';
import javalab, {toggleDarkMode} from '@cdo/apps/javalab/javalabRedux';
import color from '@cdo/apps/util/color';
global.$ = require('jquery');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious: Why is this needed? I would have expected jquery to already exist here.

Copy link
Contributor Author

@JillianK JillianK Apr 8, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JavalabView gave me an error when I tried to run the tests without it so I guess it didn't exist

jmkulwik
jmkulwik approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@jmkulwik jmkulwik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@jmkulwik
Copy link
Contributor

Already signed off, but here's my ✔️ for the new set of changes!

@JillianK JillianK merged commit fb52fd8 into staging Apr 14, 2021
@JillianK JillianK deleted the jk-light-mode branch April 14, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmkulwik jmkulwik jmkulwik approved these changes

@molly-moen molly-moen molly-moen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JillianK @jmkulwik @molly-moen