Add RGB pulse function #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisher-alice
commented
Oct 13, 2022
| }, | ||
| // state.prev records the last color set using color(), | ||
| // and is used to determine the new color when calling on() or pulse() | ||
| prev: { |
There was a problem hiding this comment.
state.prev was added in prior implementation as well. @islemaster adeptly explains the reasoning for this addition here.
fisher-alice
commented
Oct 13, 2022
| // uses state.prev for the current color | ||
| pulse(duration, callback) { | ||
| const state = priv.get(this); | ||
| var currentColor = state.prev; |
There was a problem hiding this comment.
pulse() uses the last color set using color(), saved to state.prev instead of checking the actual current color of the RGB as done in the prior implementation of pulse(). This is to avoid a problem where subsequent calls to pulse would lead to smaller and smaller intensity ranges. @islemaster gives an example of this case here.
fisher-alice
commented
Oct 13, 2022
| pulse(duration, callback) { | ||
| const state = priv.get(this); | ||
| var currentColor = state.prev; | ||
| this.stop(); |
There was a problem hiding this comment.
Doc for segment properties.
…reuse Animation.keys
This was referenced Nov 30, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the code-dot-org/johnny-five is updated to the latest release from upstream, this PR re-implements the
rgb.pulsefunction in theRGBclass. Refer to this PR for the past implementation of this function.The implementation of pulse was very similar to past implementation by @islemaster. However I kept the upstream implementation of
Animation.renderinrgb.js.Also, in
rgb.jsI had to move the assignment of Animation.keys after RGB.colors was defined. When I first implemented thepulsefunction, I received an error due to the fact thatAnimation.keyswas not defined correctly.Looking in
rgb.js, the reason was thatRGB.colorswas not assigned yet. So I placed theRGB.colorsassignment before theAnimation.keyswas assigned to it. I also added clarifying comments in thetweenedValuesfunction where an error was being thrown before the fix.Comments are embedded for more details of implementation.
Links
jira - Re-add LED pulse to johnny-five
Testing
I ran the johnny-five tests locally using
grunt:I also tested locally with the Circuit Playground. Videos are below.
This is a program that toggles between
rgb.pulseandrgb.blink:pulse.and.blink.mp4
This is a program that shows both 'rgb.pulse
andled.pulse`:compare.led.and.rgb.pulse.mp4