Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor themes #370

Merged
merged 12 commits into from
Jun 8, 2023
Merged

Refactor themes #370

merged 12 commits into from
Jun 8, 2023

Conversation

pomber
Copy link
Contributor

@pomber pomber commented Jun 6, 2023

📦 Published PR as canary version: 0.9.0--canary.370.d5dcee5.0

✨ Test out this PR locally via:

npm install @code-hike/mdx@0.9.0--canary.370.d5dcee5.0
# or 
yarn add @code-hike/mdx@0.9.0--canary.370.d5dcee5.0

Version

Published prerelease version: v0.9.0-next.0

Changelog

🚀 Enhancement

🐛 Bug Fix

Authors: 1

@vercel
Copy link

vercel bot commented Jun 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chtest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 8, 2023 1:36pm
playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 8, 2023 1:36pm

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

📦 Next.js Bundle Analysis for bundle-test

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 74.59 KB (🟡 +301 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/just-code 32.18 KB 106.77 KB 30.51% (🟢 -0.39%)
/scrollycoding-preview 35.27 KB 109.86 KB 31.39% (🟢 -0.38%)
/spotlight 32.73 KB 107.32 KB 30.66% (🟢 -0.38%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@vercel vercel bot temporarily deployed to Preview – playground June 6, 2023 12:48 Inactive
@vercel vercel bot temporarily deployed to Preview – chtest June 6, 2023 12:49 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

📦 Next.js Bundle Analysis for bundle-test

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 74.63 KB (🟡 +342 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/just-code 26.38 KB 101.01 KB 28.86% (🟢 -2.04%)
/scrollycoding-preview 29.44 KB 104.07 KB 29.73% (🟢 -2.04%)
/spotlight 26.93 KB 101.56 KB 29.02% (🟢 -2.04%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@pomber pomber added minor release PR created automatically for new releases labels Jun 7, 2023
@vercel vercel bot temporarily deployed to Preview – chtest June 7, 2023 15:42 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

📦 Next.js Bundle Analysis for bundle-test

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 74.63 KB (🟡 +341 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/just-code 26.39 KB 101.02 KB 28.86% (🟢 -2.03%)
/scrollycoding-preview 29.45 KB 104.08 KB 29.74% (🟢 -2.05%)
/spotlight 26.94 KB 101.57 KB 29.02% (🟢 -2.04%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@vercel vercel bot temporarily deployed to Preview – chtest June 7, 2023 15:48 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

📦 Next.js Bundle Analysis for bundle-test

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 74.63 KB (🟡 +341 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/just-code 26.39 KB 101.02 KB 28.86% (🟢 -2.03%)
/scrollycoding-preview 29.45 KB 104.08 KB 29.74% (🟢 -2.05%)
/spotlight 26.94 KB 101.57 KB 29.02% (🟢 -2.04%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@vercel vercel bot temporarily deployed to Preview – playground June 7, 2023 15:53 Inactive
@vercel vercel bot temporarily deployed to Preview – playground June 8, 2023 12:28 Inactive
@vercel vercel bot temporarily deployed to Preview – chtest June 8, 2023 12:30 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

📦 Next.js Bundle Analysis for bundle-test

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 74.63 KB (🟡 +341 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/just-code 26.33 KB 100.96 KB 28.85% (🟢 -2.06%)
/scrollycoding-preview 29.39 KB 104.02 KB 29.72% (🟢 -2.06%)
/spotlight 26.88 KB 101.51 KB 29.00% (🟢 -2.05%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@vercel vercel bot temporarily deployed to Preview – playground June 8, 2023 13:35 Inactive
@vercel vercel bot temporarily deployed to Preview – chtest June 8, 2023 13:36 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

📦 Next.js Bundle Analysis for bundle-test

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 74.63 KB (🟡 +341 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/just-code 26.33 KB 100.96 KB 28.85% (🟢 -2.06%)
/scrollycoding-preview 29.39 KB 104.02 KB 29.72% (🟢 -2.06%)
/spotlight 26.88 KB 101.51 KB 29.00% (🟢 -2.05%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@pomber pomber merged commit 52738ce into next Jun 8, 2023
@pomber pomber deleted the new-themes branch June 8, 2023 14:28
@github-actions
Copy link
Contributor

🚀 PR was released in v0.9.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release PR created automatically for new releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add data-ch-theme attribute Ability to switch themes?
1 participant