Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array types support #56

Open
tillkruss opened this issue Jan 27, 2023 · 9 comments
Open

Array types support #56

tillkruss opened this issue Jan 27, 2023 · 9 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@tillkruss
Copy link
Contributor

Our builds fails because:

Error: The hint on "getBytes" at @return is invalid: "array{int, int}"
Error: The hint on "bytes" at @return is invalid: "array{int, int}"

Is this something you're looking to support?

@williamdes
Copy link
Member

Sure, see #51
Can you try the -dev phar?
I am waiting on some final action upstream to finalize this
But since it's phpstan based it should unlock a lof of awesomeness

@williamdes williamdes added bug Something isn't working enhancement New feature or request labels Jan 27, 2023
@williamdes
Copy link
Member

/cc @jaapio do you need help to finish the implementation?

@tillkruss
Copy link
Contributor Author

@williamdes, can I use the dev version somewhat reliably?

@williamdes
Copy link
Member

@williamdes, can I use the dev version somewhat reliably?

If it runs fine, yes
There is nothing very different, just some changes a bit unstable
But if it works it's worth trying it until this gets better

@jaapio
Copy link

jaapio commented Jan 27, 2023

Some of my PR's are rejected on phpstan. So I need to find a solution. Also the nullable types are not fully supported yet.

If you have time to have a look, that would be great. Mine is currently very limited

@williamdes
Copy link
Member

Can you link them here?

@jaapio
Copy link

jaapio commented Jan 27, 2023

Still under discussion? phpstan/phpdoc-parser#166
phpstan/phpdoc-parser#165

@jaapio
Copy link

jaapio commented Jan 27, 2023

phpDocumentor/TypeResolver#180 would be nice to be resolved.
And symfony/symfony#48211 (comment) seems to be a bc break that needs to be addressed.

@tillkruss
Copy link
Contributor Author

@williamdes works great, thanks! Feel free to close.

dbu added a commit to rokka-io/rokka-client-php that referenced this issue Jun 5, 2024
dbu added a commit to rokka-io/rokka-client-php that referenced this issue Jun 5, 2024
dbu added a commit to rokka-io/rokka-client-php that referenced this issue Jun 5, 2024
dbu added a commit to rokka-io/rokka-client-php that referenced this issue Jun 5, 2024
dbu added a commit to rokka-io/rokka-client-php that referenced this issue Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Development

No branches or pull requests

3 participants