Skip to content

Conversation

ddejesus18
Copy link

No description provided.

@allanbreyes
Copy link

Gemfile updates should be committed with Gemfile.lock; otherwise, the application ships/commits as a broken state.

@ddejesus18
Copy link
Author

Hi Allan,

So should I take out the gem included in the Gem file or should I include
both?

Diana

On Sun, Oct 4, 2015 at 4:19 PM, Allan Reyes notifications@github.com
wrote:

Gemfile updates should be committed with Gemfile.lock; otherwise, the
application ships/commits as a broken state.


Reply to this email directly or view it on GitHub
#5 (comment)
.

@claytonflesher
Copy link

Diana,

If you run bundle install after adding the gem to Gemfile, it should automatically update Gemfile.lock. Then all you have to do is push the Gemfile.lock to this branch and it'll update the pull request for you.

@ddejesus18
Copy link
Author

Thanks for explaining. I will do that.

On Tue, Oct 6, 2015 at 6:55 AM, Calvyn82 notifications@github.com wrote:

Diana,

If you run bundle install after adding the gem to Gemfile, it should
automatically update Gemfile.lock. Then all you have to do is push the
Gemfile.lock to this branch and it'll update the pull request for you.


Reply to this email directly or view it on GitHub
#5 (comment)
.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants