Skip to content

Commit

Permalink
Re-enable notebook smoke tests (microsoft#139127)
Browse files Browse the repository at this point in the history
  • Loading branch information
mjbvz authored Dec 15, 2021
1 parent 76da444 commit 995c43b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion automation/src/playwrightDriver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ async function launchBrowser(options: LaunchOptions, endpoint: string) {
}
});

const payloadParam = `[["enableProposedApi",""],["skipWelcome","true"]]`;
const payloadParam = `[["enableProposedApi",""],["webviewExternalEndpointCommit","69df0500a8963fc469161c038a14a39384d5a303"],["skipWelcome","true"]]`;
await measureAndLog(page.goto(`${endpoint}&folder=vscode-remote://localhost:9888${URI.file(workspacePath!).path}&payload=${payloadParam}`), 'page.goto()', logger);

return { browser, context, page };
Expand Down
6 changes: 3 additions & 3 deletions smoke/src/areas/notebook/notebook.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export function setup(logger: Logger) {
cp.execSync('git reset --hard HEAD --quiet', { cwd: app.workspacePathOrFolder });
});

it.skip('inserts/edits code cell', async function () {
it('inserts/edits code cell', async function () {
const app = this.app as Application;
await app.workbench.notebook.openNotebook();
await app.workbench.notebook.focusNextCell();
Expand Down Expand Up @@ -54,7 +54,7 @@ export function setup(logger: Logger) {
await app.workbench.notebook.waitForMarkdownContents('p', 'Markdown Cell');
});

it.skip('moves focus in and out of output', async function () { // TODO@rebornix https://github.com/microsoft/vscode/issues/113882
it('moves focus in and out of output', async function () { // TODO@rebornix https://github.com/microsoft/vscode/issues/113882
const app = this.app as Application;
await app.workbench.notebook.openNotebook();
await app.workbench.notebook.executeActiveCell();
Expand All @@ -63,7 +63,7 @@ export function setup(logger: Logger) {
await app.workbench.notebook.waitForActiveCellEditorContents('code()');
});

it.skip('cell action execution', async function () {
it('cell action execution', async function () {
const app = this.app as Application;
await app.workbench.notebook.openNotebook();
await app.workbench.notebook.insertNotebookCell('code');
Expand Down

0 comments on commit 995c43b

Please sign in to comment.