Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with Notebook smoke/web tests #126371

Open
joaomoreno opened this issue Jun 15, 2021 · 15 comments · Fixed by #139127
Open

Deal with Notebook smoke/web tests #126371

joaomoreno opened this issue Jun 15, 2021 · 15 comments · Fixed by #139127
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues notebook
Milestone

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Jun 15, 2021

The entire Notebook smoke test suite is currently entirely skipped. We should address this by either fixing the tests or removing them altogether.

cc @jrieken @roblourens

@rebornix
Copy link
Member

I'll recommend us removing them.

@rebornix rebornix removed their assignment Jun 15, 2021
@bpasero
Copy link
Member

bpasero commented Jun 15, 2021

Related, they are entirely disabled for web in integration tests: #126384

@roblourens
Copy link
Member

Current status: I'd like to delete the ones that have just always been flaky but leave at least a couple so we open a notebook during smoketesting. But opening a notebook fails in the web smoketests due to something with the webview.

@mjbvz mjbvz modified the milestones: June 2021, July 2021 Jun 30, 2021
@roblourens roblourens modified the milestones: July 2021, August 2021 Jul 29, 2021
@roblourens
Copy link
Member

roblourens commented Aug 7, 2021

@mjbvz can you look at this? I also can't do a web integration test for (I think) the same reason.

Error loading webview: Error: Could not register service workers: TypeError: Failed to register a ServiceWorker for scope ('https://a3772875-0e58-451e-80db-0d430bdac14d.vscode-webview-test.com/5319757634f77a050b49c10162939bfe60970c29/') with script ('https://a3772875-0e58-451e-80db-0d430bdac14d.vscode-webview-test.com/5319757634f77a050b49c10162939bfe60970c29/service-worker.js?id=a3772875-0e58-451e-80db-0d430bdac14d&swVersion=2&extensionId=&platform=browser&vscode-resource-base-authority=vscode-resource.vscode-webview.net&purpose=notebookRenderer'): An unknown error occurred when fetching the script..

Works like in yarn web though, I don't know what the difference is

mjbvz added a commit to mjbvz/vscode that referenced this issue Aug 12, 2021
mjbvz added a commit to mjbvz/vscode that referenced this issue Aug 12, 2021
@mjbvz mjbvz modified the milestones: September 2021, On Deck Sep 16, 2021
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug notebook labels Oct 11, 2021
@rebornix rebornix removed their assignment Oct 22, 2021
@bpasero
Copy link
Member

bpasero commented Dec 10, 2021

I would like to enrich our hot-exit smoke tests to also open a notebook, make it dirty and verify the contents are there after restart. But given the notebook tests are disabled, it looks I am blocked on this? What is the status?

@roblourens
Copy link
Member

@mjbvz would you have time to look at this in December/Jan?

@mjbvz mjbvz removed this from the On Deck milestone Dec 11, 2021
@rebornix rebornix modified the milestones: September 2022, October 2022 Sep 29, 2022
@rebornix rebornix modified the milestones: October 2022, November 2022 Oct 21, 2022
@rebornix rebornix removed their assignment Nov 23, 2022
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
For microsoft#126371

This single test passes for me. Will look at re-enabling individual tests next
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@mjbvz mjbvz modified the milestones: January 2023, February 2023 Jan 24, 2023
@mjbvz mjbvz modified the milestones: February 2023, March 2023 Feb 21, 2023
mjbvz added a commit that referenced this issue Mar 16, 2023
@mjbvz mjbvz modified the milestones: March 2023, April 2023 Mar 20, 2023
@mjbvz mjbvz modified the milestones: April 2023, May 2023 Apr 24, 2023
@mjbvz mjbvz modified the milestones: May 2023, On Deck May 11, 2023
@mjbvz mjbvz added debt Code quality issues and removed smoke-test-failure labels Oct 9, 2023
meslubi2021 added a commit to meslubi2021/vscode that referenced this issue Aug 10, 2024
For microsoft#126371

Co-authored-by: Matt Bierner <matb@microsoft.com>
@DonJayamanne DonJayamanne assigned DonJayamanne and unassigned roblourens and mjbvz Dec 10, 2024
@DonJayamanne
Copy link
Contributor

Removing @mjbvz for now from this, as it seems there might no longer be an issue.
Will need to enable the tests and verify once again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues notebook
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants
@joaomoreno @roblourens @rebornix @bpasero @DonJayamanne @mjbvz and others