Skip to content

Commit

Permalink
fix(utils,cli): remove all mentions of the interactive option (#245)
Browse files Browse the repository at this point in the history
Close #120
  • Loading branch information
IKatsuba authored Nov 13, 2023
1 parent 84b8c28 commit be7471e
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
2 changes: 1 addition & 1 deletion packages/cli/src/lib/implementation/model.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Format, GlobalOptions } from '@code-pushup/models';

// type GeneralCliOnlyOptions = { progress: boolean }; // @TODO consider interactive and progress as CLI only options
// type GeneralCliOnlyOptions = { progress: boolean }; // @TODO consider progress as CLI only options
export type GeneralCliOptions = GlobalOptions;

export type CoreConfigCliOptions = {
Expand Down
8 changes: 4 additions & 4 deletions packages/utils/src/lib/execute-process.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -86,15 +86,15 @@ describe('objectToCliArgs', () => {
});

it('should handle boolean arguments', () => {
const params = { interactive: true };
const params = { progress: true };
const result = objectToCliArgs(params);
expect(result).toEqual(['--interactive']);
expect(result).toEqual(['--progress']);
});

it('should handle negated boolean arguments', () => {
const params = { interactive: false };
const params = { progress: false };
const result = objectToCliArgs(params);
expect(result).toEqual(['--no-interactive']);
expect(result).toEqual(['--no-progress']);
});

it('should handle array of string arguments', () => {
Expand Down
1 change: 0 additions & 1 deletion packages/utils/src/lib/execute-process.ts
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,6 @@ export type CliArgsObject<T extends object = Record<string, ArgumentValue>> =
* const args = objectToProcessArgs({
* _: ['node', 'index.js'], // node index.js
* name: 'Juanita', // --name=Juanita
* interactive: false, // --no-interactive
* formats: ['json', 'md'] // --format=json --format=md
* });
*/
Expand Down

0 comments on commit be7471e

Please sign in to comment.