fix(utils): always log single perfect audit

code-pushup · Oct 23, 2024 · d8a7eb2 · d8a7eb2
1 parent 924a8bf
commit d8a7eb2
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 3 deletions.
diff --git a/packages/utils/src/lib/reports/log-stdout-summary.ts b/packages/utils/src/lib/reports/log-stdout-summary.ts
@@ -39,9 +39,10 @@ export function logPlugins(
 ): void {
   plugins.forEach(plugin => {
     const { title, audits } = plugin;
-    const filteredAudits = verbose
-      ? audits
-      : audits.filter(({ score }) => score !== 1);
+    const filteredAudits =
+      verbose || audits.length === 1
+        ? audits
+        : audits.filter(({ score }) => score !== 1);
     const diff = audits.length - filteredAudits.length;
 
     logAudits(title, filteredAudits);

diff --git a/packages/utils/src/lib/reports/log-stdout-summary.unit.test.ts b/packages/utils/src/lib/reports/log-stdout-summary.unit.test.ts
@@ -255,6 +255,21 @@ describe('logPlugins', () => {
     expect(output).toContain('Audit 1');
     expect(output).toContain('Audit 2');
   });
+
+  it('should not truncate a perfect audit in non-verbose mode when it is the only audit available', () => {
+    logPlugins(
+      [
+        {
+          title: 'Best Practices',
+          slug: 'best-practices',
+          audits: [{ title: 'Audit 1', score: 1, value: 100 }],
+        },
+      ] as ScoredReport['plugins'],
+      false,
+    );
+    const output = logs.join('\n');
+    expect(output).toContain('Audit 1');
+  });
 });
 
 describe('binaryIconPrefix', () => {