Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add package utils for cli independent logic #39

Merged
merged 84 commits into from
Sep 7, 2023
Merged

Add package utils for cli independent logic #39

merged 84 commits into from
Sep 7, 2023

Conversation

BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Sep 6, 2023 •
edited by matejchalk
Loading

Closes #32

This PR focuses on the CLI independent logic for the collect command.

It includes:

  • source code + JsDocs
  • unit tests
  • test helper
  • mock data
  • adoptions for libs (make them buildable)

BioPhoton and others added 30 commits August 31, 2023 00:53
@BioPhoton
feat(models): setup types and parser with zod
d067799
@BioPhoton
fix(models): add package.lock
46d4408
@BioPhoton
refactor(models): format
0e5ef27
@BioPhoton
refactor(models): align package.json
1369565
@BioPhoton
refactor(models): format
63c1bcc
@BioPhoton
refactor(models): package.lock
8096b85
@BioPhoton @matejchalk
Update packages/models/project.json
70fc405 
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton @matejchalk
Update packages/models/project.json
c885349 
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton
feat(utils): add collect utils
a71955e
@BioPhoton
refactor(models): remove budgets from initial code base
337c9c2
@BioPhoton @matejchalk
Update packages/models/src/lib/category-config.ts
aaa17a5 
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton
refactor(models): remove budgets
0a67872
@BioPhoton
Merge branch 'main' into add-package-for-cli-independent-logic
2ce3136
@BioPhoton @matejchalk
Update packages/models/src/lib/plugins.ts
48dd062 
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton @matejchalk
Update packages/models/src/lib/plugins.ts
3b35871 
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton @matejchalk
Update packages/models/src/lib/upload.ts
34ceba1 
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton @matejchalk
Update packages/models/src/lib/upload.ts
71c5a4d 
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton
refactor(models): add int and non negative validators
05486fd
@BioPhoton
refactor(models): add cross field validators
23cf79a
@BioPhoton
refactor(models): format files
d52de86
@BioPhoton
refactor(models): implement feedback from PR, format
b9e1244
@BioPhoton
Merge branch 'main' into add-package-for-cli-independent-logic
8dc0e53
@BioPhoton @matejchalk
Update packages/models/project.json
9bc21e6 
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton @matejchalk
Update packages/models/src/lib/category-config.ts
20ccf92 
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton @matejchalk
Update packages/models/src/lib/implementation/schemas.ts
401ed9a 
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton @matejchalk
Update packages/models/src/lib/category-config.ts
cbee718 
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton @matejchalk
Update packages/models/src/lib/core-config.spec.ts
a000ee9 
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton @matejchalk
Update packages/models/src/lib/output.ts
651498b 
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton @matejchalk
Update packages/models/src/lib/output.ts
4ec4bc4 
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton @matejchalk
Update packages/models/src/lib/plugins.ts
c0b4164 
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton BioPhoton requested a review from matejchalk September 6, 2023 19:55
matejchalk
matejchalk requested changes Sep 7, 2023
View reviewed changes
packages/utils/src/lib/collect/implementation/execute-plugin.spec.ts Outdated Show resolved Hide resolved
packages/utils/src/lib/collect/implementation/execute-plugin.ts Outdated Show resolved Hide resolved
packages/utils/src/lib/collect/implementation/execute-plugin.ts Outdated Show resolved Hide resolved
packages/utils/src/lib/collect/implementation/execute-plugin.ts Show resolved Hide resolved
packages/utils/src/lib/collect/implementation/execute-plugin.ts Outdated Show resolved Hide resolved
packages/utils/src/lib/collect/index.ts Outdated Show resolved Hide resolved
packages/utils/src/lib/collect/index.ts Outdated Show resolved Hide resolved
packages/utils/src/lib/collect/index.ts Outdated Show resolved Hide resolved
packages/models/package.json Outdated Show resolved Hide resolved
packages/utils/package.json Outdated Show resolved Hide resolved
BioPhoton and others added 11 commits September 7, 2023 11:35
@BioPhoton @matejchalk
Update packages/utils/src/lib/collect/implementation/execute-plugin.s…
c62b0af 
…pec.ts

Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton @matejchalk
Update packages/utils/src/lib/collect/implementation/execute-plugin.ts
2b87136 
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton @matejchalk
Update packages/utils/src/lib/collect/implementation/execute-plugin.ts
dfbb504 
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton @matejchalk
Update packages/utils/src/lib/collect/implementation/execute-plugin.ts
9acdc40 
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton @matejchalk
Update packages/utils/src/lib/collect/index.ts
b5fb118 
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton @matejchalk
Update packages/utils/src/lib/collect/implementation/mock/execute-pro…
61046d6 
…cess.mock.mjs

Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton @matejchalk
Update packages/utils/src/lib/collect/implementation/mock/process-hel…
8e02d5a 
…per.mock.ts

Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton
feat(cli): refactor types, adopt lib setup for build and test
19a68b0
@BioPhoton
feat(utils): format
7a2ca23
@BioPhoton
feat(utils): lint fix
22bf8d2
@BioPhoton
feat(utils): fix build
5d9ed9c
matejchalk
matejchalk reviewed Sep 7, 2023
View reviewed changes
packages/utils/src/lib/collect/implementation/execute-process.spec.ts Outdated Show resolved Hide resolved
packages/models/package.json Outdated Show resolved Hide resolved
packages/cli/package.json Outdated Show resolved Hide resolved
BioPhoton and others added 2 commits September 7, 2023 15:08
@BioPhoton @matejchalk
Update packages/utils/src/lib/collect/implementation/execute-process.…
58a1860 
…spec.ts

Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton @matejchalk
Apply suggestions from code review
f6829cf 
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
matejchalk
matejchalk previously approved these changes Sep 7, 2023
View reviewed changes
@BioPhoton BioPhoton requested a review from matejchalk September 7, 2023 13:23
@BioPhoton BioPhoton merged commit dacaaf7 into main Sep 7, 2023
@BioPhoton BioPhoton deleted the add-package-for-cli-independent-logic branch September 7, 2023 13:30
BioPhoton added a commit that referenced this pull request Sep 7, 2023
@BioPhoton @matejchalk
feat(utils): add package utils for cli independent logic (#39)
409883b 
Closes #32

This PR focuses on the CLI independent logic for the collect command.

It includes:
- source code + JsDocs
- unit tests
- test helper
- mock data
- adoptions for libs (make them buildable)

---------

Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton BioPhoton mentioned this pull request Oct 18, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejchalk matejchalk matejchalk approved these changes

@vmasek vmasek Awaiting requested review from vmasek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up utils package to encapsulate plain logic from the CLI
2 participants
@BioPhoton @matejchalk