Skip to content

Conversation

@BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Oct 17, 2023

This PR includes the basic setup to version our packages.

A couple of things I want to point out here:

  • I added all configurations of version to the targetDefaults
    This reduces the duplicated options and leaves the project.json with just "version": {} as target

  • I did NOT add version as a cache target under tasksRunnerOptions
    As the result is idempotent. It if there is no new change in the git history it will just pass.

  • We could consider the history by adding tags, to restore a bit of the changes we did before versioning

    Todos:

    • add version targets
    • configure nx.json
    • add github target

Action setup is done in another PR

related to #8

@BioPhoton
Copy link
Collaborator Author

Example of current readme:

The scopes and packages don't seem to be related, or we have a bad commit hygiene :D
I would like to discuss this asap.


Changelog

This file was generated using @jscutlery/semver.

0.1.0 (2023-10-17)

Features

  • cli: initial collect command (#45) (ba048be)
  • cli: persist login and formatting options (#47) (6241fd7)

0.1.0 (2023-10-17)

Features

  • cli: initial collect command (#45) (ba048be)
  • cli: persist login and formatting options (#47) (6241fd7)
  • cli: setup yargs for cli (#42) (37ea0a5), closes #6 #38
  • cli: use bundle-require instead of jiti (no hackfix, but also no CJS configs) (028c592)
  • configure build and tests to handle ESM and CJS configs (48cd967)
  • models: validate plugin icons using portal-client package (f52cc75)
  • support TS config files using Jiti + hackfix lighthouse import.meta usages (3b7927d)
  • utils: add file size logging (#65) (c46046f), closes #59
  • utils: add package utils for cli independent logic (#39) (dacaaf7), closes #32
  • utils: add upload logic (#66) (3e88ffc), closes #21 #57 #85
  • utils: move parts from utils into core (#81) (dd0a180), closes #78

Bug Fixes

  • cli: run npm install before tests (6507c2e)
  • lint config and errors (6f5f677)
  • refactor after core package intro (#83) (aa39d09)

Code Refactoring

  • add version targets and (0d5b87c)
  • chore: improvements testing (#46) (ce21d87)
  • cli: prepare for core package (#80) (0c915f0), closes #73 #79
  • cli: rename configPath to config (#109) (daf548d)
  • models: add global options (#76) (28966a2), closes #73
  • models: name file related path more specific (#102) (fff1ae2), closes #96
  • models: refine data structure (#55) (f94933b), closes #50
  • move config loading tests to cli-e2e project (16cd86d)
  • purge remaining jest references (3c6c0ae)
  • utils: add package.json metadata to report in cli, not utils (7d3de10)

@BioPhoton BioPhoton self-assigned this Oct 19, 2023
@BioPhoton BioPhoton added the 🦾 CI/CD Continuous integration and deployment label Oct 19, 2023
@BioPhoton BioPhoton added this to the 1. Internal MVP milestone Oct 19, 2023
Copy link
Collaborator Author

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready for review

@BioPhoton
Copy link
Collaborator Author

What i was wondering is can we reduce the changelog to a specific folder. that would help a lot with duplicates etc in different packages

@matejchalk
Copy link
Collaborator

What i was wondering is can we reduce the changelog to a specific folder. that would help a lot with duplicates etc in different packages

I don't necessarily mind that there are multiple changelog files 🤷‍♂️ It makes sense to distribute it with each NPM package (i.e. it should get copied to dist).

@BioPhoton BioPhoton merged commit ba0c337 into main Nov 16, 2023
@BioPhoton BioPhoton deleted the setup-tags branch November 16, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🦾 CI/CD Continuous integration and deployment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants