-
Notifications
You must be signed in to change notification settings - Fork 15
ci: setup git tags #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: setup git tags #126
Conversation
|
Example of current readme: The scopes and packages don't seem to be related, or we have a bad commit hygiene :D ChangelogThis file was generated using @jscutlery/semver. 0.1.0 (2023-10-17)Features
0.1.0 (2023-10-17)Features
Bug Fixes
Code Refactoring
|
BioPhoton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ready for review
|
What i was wondering is can we reduce the changelog to a specific folder. that would help a lot with duplicates etc in different packages |
I don't necessarily mind that there are multiple changelog files 🤷♂️ It makes sense to distribute it with each NPM package (i.e. it should get copied to |
This PR includes the basic setup to version our packages.
A couple of things I want to point out here:
I added all configurations of
versionto thetargetDefaultsThis reduces the duplicated options and leaves the
project.jsonwith just"version": {}as targetI did NOT add
versionas a cache target undertasksRunnerOptionsAs the result is idempotent. It if there is no new change in the git history it will just pass.
We could consider the history by adding tags, to restore a bit of the changes we did before versioning
Todos:
versiontargetsnx.jsonAction setup is done in another PR
related to #8