Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): persist login and formatting options #47

Merged
merged 43 commits into from
Sep 17, 2023
Merged

feat(cli): persist login and formatting options #47

merged 43 commits into from
Sep 17, 2023

Conversation

BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Sep 9, 2023 •
edited
Loading

This PR implements:

  • a format option on the collect logic
  • a persistReport function
  • formatters for the following report formats:
    • stdout
    • json
    • md
      • helpers to transform data to markdown
  • nearly all tests
  • a clumsy way to mock console.log's

to discuss :

  • We should probably consider using header for Plugins and audit details and then place results in tables ?
  • and probably even the details.issues (for ESLint audits - at least a summary of how many errors, warnings, etc. were found).

closes #20

@BioPhoton BioPhoton requested a review from matejchalk September 9, 2023 01:50
@ChristopherPHolder
Copy link

@BioPhoton Does this run locally?

I get typing errors when trying it locally.

matejchalk
matejchalk requested changes Sep 12, 2023
View reviewed changes
package-lock.json Outdated Show resolved Hide resolved
packages/models/src/lib/report.ts Outdated Show resolved Hide resolved
packages/utils/docs/report.md Outdated Show resolved Hide resolved
packages/utils/docs/report.md Outdated Show resolved Hide resolved
packages/utils/docs/report.md Outdated Show resolved Hide resolved
packages/utils/src/lib/collect/implementation/md/link.ts Show resolved Hide resolved
packages/utils/src/lib/collect/implementation/md/list.ts Outdated Show resolved Hide resolved
packages/utils/src/lib/collect/implementation/persist.ts Outdated Show resolved Hide resolved
packages/utils/src/lib/collect/implementation/report.ts Outdated Show resolved Hide resolved
packages/utils/src/lib/collect/index.ts Outdated Show resolved Hide resolved
matejchalk
matejchalk reviewed Sep 12, 2023
View reviewed changes
packages/utils/docs/report.md Outdated Show resolved Hide resolved
packages/utils/docs/report.md Outdated Show resolved Hide resolved
packages/utils/src/lib/collect/implementation/persist.spec.ts Show resolved Hide resolved
BioPhoton and others added 15 commits September 12, 2023 15:08
@BioPhoton @matejchalk
Update packages/utils/src/lib/collect/index.ts
36cfa02 
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton
refactor(utils): adopt md report sections
54b9a8a
@BioPhoton
test(utils): md, and md report
190c6d1
@BioPhoton
test(utils): stdout report and schema comments
32739ae
@BioPhoton
chore(cli): insatll
ce1e2ad
@BioPhoton
fix(utils): build
4c37f95
@BioPhoton
fix(utils): test adoptions
85269bf
@BioPhoton
refactor(utils): format
cb0842c
@BioPhoton
test(utils): fix tests
c8f269e
@BioPhoton @matejchalk
Update packages/utils/src/lib/collect/implementation/md/constants.ts
ff48106 
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton @matejchalk
Update packages/utils/src/lib/collect/implementation/md/details.ts
193143c 
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton
fix(utils): fix imports
bfb7a1d
@ChristopherPHolder
test(utils): fix to match regex
12e808b
@BioPhoton
fix(utils): format
01017e8
@BioPhoton
fix(utils): imports
4b73ad6
matejchalk
matejchalk reviewed Sep 16, 2023
View reviewed changes
packages/cli/project.json Outdated Show resolved Hide resolved
packages/models/src/lib/report.ts Outdated Show resolved Hide resolved
packages/utils/src/lib/collect/implementation/md/font-style.ts Outdated Show resolved Hide resolved
packages/utils/src/lib/collect/implementation/md/list.ts Outdated Show resolved Hide resolved
packages/utils/src/lib/collect/implementation/md/list.spec.ts Outdated Show resolved Hide resolved
BioPhoton and others added 5 commits September 16, 2023 10:54
@BioPhoton @matejchalk
Update packages/utils/src/lib/collect/implementation/md/font-style.ts
9457f69 
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton @matejchalk
Update packages/utils/src/lib/collect/implementation/md/list.ts
b0577b2 
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton @matejchalk
Update packages/utils/src/lib/collect/implementation/md/list.spec.ts
456f05b 
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton
test(chore): introduce shared test helper
d1bbeb6
@BioPhoton
test(chore): introduce shared test helper
7825d0a
BioPhoton and others added 18 commits September 16, 2023 11:21
@BioPhoton
test(chore): fix mock data
bd8435d
@BioPhoton
refactor(chore): format
469d344
@BioPhoton
refactor(chore): polish
cae5fb7
@BioPhoton
fix(models): testing exports
028f2ca
@BioPhoton
merge test improvements 1
54543b8
@BioPhoton
refactor(cli): merge testing improvements
10f2a57
@BioPhoton
refactor(chore): improvements testing (#46)
caa2cfa 
This PR includes:
- a refactoring for the test helper to mock schemas
- updated imports
- adoptions to the schemas (removes `label`)
@BioPhoton
refactor(cli): merge master, fix issues
0b09cd6
@BioPhoton
refactor(cli): fix issues
9c1fdbd
@BioPhoton
refactor(cli): fix issues 2
9fb6905
@BioPhoton
Merge branch 'main' into print-report-to-console
17c44df 
# Conflicts:
#	package-lock.json
#	packages/models/src/lib/implementation/schemas.ts
#	packages/models/src/lib/plugin-config.spec.ts
#	packages/models/src/lib/plugin-config.ts
#	packages/models/src/lib/report.ts
#	packages/models/test/helpers.mock.ts
#	packages/models/test/index.ts
#	packages/utils/src/lib/collect/implementation/execute-plugin.spec.ts
#	packages/utils/src/lib/collect/implementation/mock/schema-helper.mock.ts
@BioPhoton
refactor(cli): fix issues 4
1b5b19b
@BioPhoton
refactor(cli): fix issues 5
4e20ffb
@BioPhoton
refactor(cli): format
2dc044a
@BioPhoton
refactor(cli): fix package.json
988d140
@BioPhoton
refactor(cli): remove comments in models
bdc8d08
@BioPhoton
Merge branch 'main' into print-report-to-console
8f4406a
@BioPhoton
refactor(cli): format
7c523da
@BioPhoton BioPhoton merged commit 6241fd7 into main Sep 17, 2023
@BioPhoton BioPhoton deleted the print-report-to-console branch September 17, 2023 15:47
@BioPhoton BioPhoton mentioned this pull request Oct 18, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristopherPHolder ChristopherPHolder ChristopherPHolder left review comments

@matejchalk matejchalk matejchalk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement collect command
3 participants
@BioPhoton @ChristopherPHolder @matejchalk