Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log report file size #59

Closed
BioPhoton opened this issue Sep 22, 2023 · 0 comments · Fixed by #65
Closed

Log report file size #59

BioPhoton opened this issue Sep 22, 2023 · 0 comments · Fixed by #65
Labels
🤓 UX UX improvement for CLI users
Milestone
1. Internal MVP

Comments

@BioPhoton
Copy link
Collaborator

It helps to understand the size of produced artefacts. Let' log it.
@BioPhoton BioPhoton mentioned this issue Sep 22, 2023
Merged
@BioPhoton BioPhoton added the 🤓 UX UX improvement for CLI users label Sep 23, 2023
BioPhoton added a commit that referenced this issue Oct 1, 2023
@BioPhoton @matejchalk
feat(utils): add file size logging (#65)
c46046f 
This PR includes:
- formatBytes function and tests
- logPersisted files function and tests
- log the files in the CLI `collect` command

closes #59

---------

Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@vmasek vmasek added this to the MVP milestone Oct 6, 2023
@BioPhoton BioPhoton mentioned this issue Oct 18, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🤓 UX UX improvement for CLI users
Projects
None yet
Milestone
1. Internal MVP
Development

Successfully merging a pull request may close this issue.

feat(utils): add file size logging code-pushup/cli
2 participants
@vmasek @BioPhoton