Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format options should process md,stdout to an array #95

Closed
BioPhoton opened this issue Oct 11, 2023 · 2 comments · Fixed by #153
Closed

Format options should process md,stdout to an array #95

BioPhoton opened this issue Oct 11, 2023 · 2 comments · Fixed by #153
Assignees
@MishaSeredenkoPushBased
Labels
➕ enhancement new feature or request 🧩 utils
Milestone
1. Internal MVP

Comments

@BioPhoton
Copy link
Collaborator

BioPhoton commented Oct 11, 2023 •
edited by kristihoskova
Loading

  • Figure out what is the official separator and then change it
  • Look up in yargs documentation
  • Split up stings based up on separator
@BioPhoton BioPhoton added the ➕ enhancement new feature or request label Oct 11, 2023
@kristihoskova kristihoskova added this to the 1. Internal MVP milestone Oct 11, 2023
@ChristopherPHolder
Copy link

This is probably relevant.

https://yargs.js.org/docs/#api-reference-arraykey

@BioPhoton
Copy link
Collaborator Author

Thx @ChristopherPHolder this closes this issue i would say

@BioPhoton BioPhoton reopened this Oct 16, 2023
@kristihoskova kristihoskova added the 🆘 help wanted assistance is required label Oct 23, 2023
@matejchalk matejchalk removed the 🆘 help wanted assistance is required label Oct 24, 2023
MishaSeredenkoPushBased pushed a commit that referenced this issue Oct 25, 2023
fix(cli): changed persist format options to array
8fd23c7 
closes #95

closes #95
Merged
MishaSeredenkoPushBased added a commit that referenced this issue Oct 25, 2023
@MishaSeredenkoPushBased
fix(cli): changed persist format options to array (#153)
26c6a85 
closes #95

---------

Co-authored-by: Mikhail <mikhail.seradzenka@piercegroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MishaSeredenkoPushBased MishaSeredenkoPushBased

Labels
➕ enhancement new feature or request 🧩 utils
Projects
None yet
Milestone
1. Internal MVP
Development

Successfully merging a pull request may close this issue.

fix(cli): changed persist format options to array code-pushup/cli
5 participants
@BioPhoton @matejchalk @ChristopherPHolder @kristihoskova @MishaSeredenkoPushBased