Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(utils): relocate code for text styles #673

Merged
merged 24 commits into from
May 21, 2024
Merged

Conversation

BioPhoton
Copy link
Collaborator

No description provided.

BioPhoton and others added 18 commits May 2, 2024 17:40
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
# Conflicts:
#	packages/utils/src/lib/reports/constants.ts
#	packages/utils/src/lib/reports/generate-md-report-categoy-section.ts
#	packages/utils/src/lib/reports/generate-md-reports-diff.ts
#	packages/utils/src/lib/text-formats/html/table.ts
#	packages/utils/src/lib/text-formats/md/table.ts
#	packages/utils/src/lib/text-formats/md/table.unit.test.ts
#	packages/utils/src/lib/transform.ts
# Conflicts:
#	packages/models/src/lib/implementation/schemas.unit.test.ts
#	packages/models/src/lib/table.ts
#	packages/utils/src/lib/reports/generate-md-report-categoy-section.ts
#	packages/utils/src/lib/reports/generate-md-reports-diff.ts
#	packages/utils/src/lib/reports/html/table.ts
#	packages/utils/src/lib/reports/html/table.unit.test.ts
#	packages/utils/src/lib/reports/md/table.ts
#	packages/utils/src/lib/text-formats/md/table.unit.test.ts
@BioPhoton BioPhoton requested a review from matejchalk May 20, 2024 12:24
@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 utils labels May 20, 2024
Copy link

nx-cloud bot commented May 20, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit bb6952f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

Copy link

github-actions bot commented May 20, 2024

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 1cca669 with source commit a7d6d1b.

🏷️ Categories

🏷️ Category ⭐ Current score ⭐ Previous score 🔄 Score change
Performance 🟢 94 🟡 60 ↑ +34.2
Accessibility 🟢 98 🟢 100 ↓ −1.8
Code coverage 🟡 70 🟡 70 ↓ −0.1
Best Practices 🟢 100 🟢 100
SEO 🟡 86 🟡 86
PWA 🟡 63 🟡 63
Bug prevention 🟢 100 🟢 100
Code style 🟢 99 🟢 99
Security 🟢 94 🟢 94
Updates 🟡 70 🟡 70
Custom checks 🟡 67 🟡 67

🗃️ Groups

👍 1 group improved, 👎 2 groups regressed
🔌 Plugin 🗃️ Group ⭐ Current score ⭐ Previous score 🔄 Score change
Lighthouse Performance 🟢 94 🟡 60 ↑ +34.2
Lighthouse Accessibility 🟢 98 🟢 100 ↓ −1.8
Code coverage Code coverage metrics 🟡 70 🟡 70 ↓ −0.1

18 other groups are unchanged.

🛡️ Audits

👍 11 audits improved, 👎 3 audits regressed, 8 audits changed without impacting score
🔌 Plugin 🛡️ Audit 📏 Current value 📏 Previous value 🔄 Value change
Lighthouse Minimizes main-thread work 🟩 1.9 s 🟥 5.1 s ↓ −62 %
Lighthouse Largest Contentful Paint element 🟩 1,650 ms 🟥 3,260 ms  −∞ %
Lighthouse Background and foreground colors have a sufficient contrast ratio 🟥 0 🟩 0  −∞ %
Lighthouse Max Potential First Input Delay 🟩 120 ms 🟥 580 ms ↓ −80 %
Lighthouse Total Blocking Time 🟩 90 ms 🟥 950 ms ↓ −91 %
Lighthouse First Contentful Paint 🟩 0.9 s 🟨 2.7 s ↓ −65 %
Lighthouse Largest Contentful Paint 🟩 1.7 s 🟨 3.3 s ↓ −49 %
Lighthouse Speed Index 🟩 1.3 s 🟨 4.1 s ↓ −69 %
Lighthouse First Meaningful Paint 🟩 1.0 s 🟨 2.8 s ↓ −65 %
Lighthouse Time to Interactive 🟩 2.4 s 🟨 4.0 s ↓ −41 %
Lighthouse Cumulative Layout Shift 🟨 0.147 🟨 0.148  −∞ %
Code coverage Line coverage 🟨 66 % 🟨 67 % ↓ −1 %
Code coverage Function coverage 🟨 64 % 🟨 64 %  +0 %
Code coverage Branch coverage 🟨 82 % 🟨 82 %  +0 %
Lighthouse Metrics 🟩 2388 🟩 4039 ↓ −41 %
Lighthouse Properly size images 🟥 Potential savings of 240 KiB 🟥 Potential savings of 240 KiB ↑ +400 %
Lighthouse JavaScript execution time 🟩 0.0 s 🟩 0.1 s ↓ −74 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 432 KiB 🟩 Total size was 432 KiB ↑ +0 %
Lighthouse Uses efficient cache policy on static assets 🟨 11 resources found 🟨 11 resources found ↑ +0 %
Lighthouse Server Backend Latencies 🟩 40 ms 🟩 60 ms ↓ −25 %
Lighthouse Network Round Trip Times 🟩 10 ms 🟩 0 ms ↑ +125 %
Lighthouse Initial server response time was short 🟩 Root document took 10 ms 🟩 Root document took 10 ms ↑ +80 %

501 other audits are unchanged.

@BioPhoton BioPhoton marked this pull request as ready for review May 20, 2024 13:48
@BioPhoton BioPhoton requested a review from Tlacenka as a code owner May 20, 2024 13:48
BioPhoton and others added 2 commits May 20, 2024 18:03
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton BioPhoton requested review from matejchalk and removed request for Tlacenka May 20, 2024 16:05
@BioPhoton BioPhoton enabled auto-merge (squash) May 20, 2024 16:21
@BioPhoton BioPhoton merged commit 6005d6b into main May 21, 2024
19 checks passed
@BioPhoton BioPhoton deleted the refactor-report-styles branch May 21, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🛠️ tooling 🧩 utils
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants