Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nx-plugin): extend config generator #778

Merged
merged 13 commits into from
Aug 6, 2024
Merged

Conversation

BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Aug 2, 2024

Better generator logic to create config files

@BioPhoton BioPhoton requested a review from matejchalk August 2, 2024 13:14
@BioPhoton BioPhoton marked this pull request as ready for review August 2, 2024 13:17
Copy link

github-actions bot commented Aug 2, 2024

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 35b9f38 with source commit 7db09b9.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 48 🔴 46 ↓ −2.5
Code coverage 🟡 90 🟡 90 ↑ +0.1
Custom checks 🟡 67 🟡 67
Security 🟢 100 🟢 100
Updates 🟡 78 🟡 78
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 99 🟢 99

🗃️ Groups

👍 1 group improved, 👎 1 group regressed
🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 48 🔴 46 ↓ −2.5
Code coverage Code coverage metrics 🟡 90 🟡 90 ↑ +0.1

18 other groups are unchanged.

🛡️ Audits

👍 5 audits improved, 👎 4 audits regressed, 12 audits changed without impacting score
🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 633 KiB 🟨 Potential savings of 621 KiB ↓ −100 %
Lighthouse First Contentful Paint 🟨 2.7 s 🟥 3.3 s ↑ +20 %
Lighthouse First Meaningful Paint 🟨 2.7 s 🟨 3.4 s ↑ +26 %
Lighthouse Speed Index 🟥 6.3 s 🟥 7.6 s ↑ +21 %
Lighthouse Largest Contentful Paint 🟨 3.9 s 🟨 3.8 s ↓ −3 %
Lighthouse Time to Interactive 🟥 15.3 s 🟥 17.0 s ↑ +11 %
Code coverage Branch coverage 🟨 84 % 🟨 84.3 % ↑ +0 %
Code coverage Line coverage 🟩 91.5 % 🟩 91.6 % ↑ +0 %
Code coverage Function coverage 🟩 92 % 🟩 92.1 % ↑ +0 %
Lighthouse Minimizes main-thread work 🟥 17.9 s 🟥 24.0 s ↑ +35 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,790 KiB 🟩 Total size was 1,793 KiB ↑ +0 %
Lighthouse Total Blocking Time 🟥 6,950 ms 🟥 9,510 ms ↑ +37 %
Lighthouse JavaScript execution time 🟥 8.8 s 🟥 10.8 s ↑ +23 %
Lighthouse Metrics 🟩 15292 🟩 17015 ↑ +11 %
Lighthouse Max Potential First Input Delay 🟥 2,590 ms 🟥 3,580 ms ↑ +38 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 380 ms 🟥 Potential savings of 1,120 ms ↑ +193 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↓ +0 %
Lighthouse Server Backend Latencies 🟩 250 ms 🟩 120 ms ↓ −50 %
Lighthouse Initial server response time was short 🟩 Root document took 300 ms 🟩 Root document took 360 ms ↑ +19 %
Lighthouse Network Round Trip Times 🟩 40 ms 🟩 10 ms ↓ −66 %
Lighthouse Avoids an excessive DOM size 🟥 2,215 elements 🟥 2,216 elements ↑ +0 %

488 other audits are unchanged.

BioPhoton and others added 3 commits August 5, 2024 12:52
…nfig.ts

Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton BioPhoton requested a review from matejchalk August 5, 2024 11:37
@BioPhoton BioPhoton requested a review from matejchalk August 6, 2024 09:49
@BioPhoton BioPhoton merged commit 1041524 into main Aug 6, 2024
30 checks passed
@BioPhoton BioPhoton deleted the extend-config-generator branch August 6, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants