-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(create-cli): package to align with package managers init command #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
📖 Project documentation
improvements or additions to the project documentation
🔬 testing
writing tests
🧩 nx-plugin
🛠️ tooling
labels
Aug 2, 2024
2 tasks
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared target commit eb4f54a with source commit 304b229. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 1 group improved, 👎 2 groups regressed, 👍 1 audit improved, 👎 9 audits regressed, 11 audits changed without impacting score🗃️ Groups
17 other groups are unchanged. 🛡️ Audits
488 other audits are unchanged. |
matejchalk
reviewed
Aug 5, 2024
packages/nx-plugin/src/generators/init/generator.integration.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
…est.ts Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
matejchalk
reviewed
Aug 19, 2024
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
matejchalk
previously approved these changes
Aug 19, 2024
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
matejchalk
previously approved these changes
Aug 19, 2024
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
matejchalk
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🦾 CI/CD
continuous integration and deployment
🧩 nx-plugin
📖 Project documentation
improvements or additions to the project documentation
🔬 testing
writing tests
🛠️ tooling
🤓 UX
UX improvement for CLI users
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
I get a resource blocked error in in the skipped tests which I can not resolve.
This PR introduces a "
create
" package for thecli
package.Many package manager support this format.
npx init @code-pushup/cli
=>npm exec @code-pushup/create-cli
It includes:
nx-plugin
logicconfiguration
generator with askipNxJson
optionRelated to:
#739 cc @grizlizli