-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugin-doc-coverage): add doc-coverage-plugin to analyze documentation in ts/js projects #896
base: main
Are you sure you want to change the base?
Conversation
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared target commit c219602 with source commit c219602. 🏷️ Categories👍 1 group improved, 👍 2 audits improved, 👎 3 audits regressed, 10 audits changed without impacting score🗃️ Groups
16 other groups are unchanged. 🛡️ Audits573 other audits are unchanged. |
…anced and some code improved
…ls. Solid version working
…te unit test for runner file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good polished tests! 🧪
I made some suggestions to improve naming and other small things.
Co-authored-by: Michael Hladky <10064416+BioPhoton@users.noreply.github.com>
…test.ts Co-authored-by: Michael Hladky <10064416+BioPhoton@users.noreply.github.com>
…gration.test.ts Co-authored-by: Michael Hladky <10064416+BioPhoton@users.noreply.github.com>
Co-authored-by: Michael Hladky <10064416+BioPhoton@users.noreply.github.com>
Co-authored-by: Michael Hladky <10064416+BioPhoton@users.noreply.github.com>
Co-authored-by: Michael Hladky <10064416+BioPhoton@users.noreply.github.com>
Co-authored-by: Michael Hladky <10064416+BioPhoton@users.noreply.github.com>
Co-authored-by: Michael Hladky <10064416+BioPhoton@users.noreply.github.com>
Co-authored-by: Michael Hladky <10064416+BioPhoton@users.noreply.github.com>
Co-authored-by: Michael Hladky <10064416+BioPhoton@users.noreply.github.com>
Co-authored-by: Michael Hladky <10064416+BioPhoton@users.noreply.github.com>
Co-authored-by: Michael Hladky <10064416+BioPhoton@users.noreply.github.com>
Co-authored-by: Michael Hladky <10064416+BioPhoton@users.noreply.github.com>
Co-authored-by: Michael Hladky <10064416+BioPhoton@users.noreply.github.com>
… unused dependency, new test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the tests.
Last thing I found was a outdated readme. After that we are good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WONDERFUL!
cc @vmasek and @matejchalk
This PR includes:
E2e test will be in a followup PR
Closes #900