-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add TypeScript plugin #902
base: main
Are you sure you want to change the base?
Conversation
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared target commit 9b54309 with source commit c219602. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories(*) New category. 👍 1 group improved, 👎 1 group regressed, 👍 1 audit improved, 👎 6 audits regressed, 11 audits changed without impacting score🗃️ Groups
15 other groups are unchanged. 🛡️ Audits
570 other audits are unchanged. |
Amazing work, can't wait to give it a try in some big project, I had a brief look but I'll review later (🤔 is this a 🎄🎁?) |
@@ -25,7 +27,7 @@ | |||
"@code-pushup/portal-client": "^0.9.0", | |||
"@isaacs/cliui": "^8.0.2", | |||
"@nx/devkit": "19.8.13", | |||
"@poppinss/cliui": "^6.4.1", | |||
"@poppinss/cliui": "^6.4.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a left over
{ | ||
slug: 'language-and-environment', | ||
weight: 1, | ||
type: 'group', | ||
plugin: 'typescript', | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here we should mention the helper
Implementation of the typescript plugin mentioned in #901. It uses the compiler programatically to retrieve TypeScript diagnostics for the compiler. Those diagnostice are mapped to audits and act like linting errors/warning.
This PR includes:
Todos:
Proposed PR delivery:
@code-pushup/utils
CONTRIBUTING.md
closes #901
Example Md Report:
Code PushUp Report
🏷 Categories
Typescript
🟡 Score: 88
🛡️ Audits
ModuleResolution (Typescript)
🟥 19 (score: 0)
Issues
node_modules/@types/babel__core/index.d.ts
node_modules/@types/babel__core/index.d.ts
node_modules/@types/babel__core/index.d.ts
node_modules/@types/babel__generator/index.d.ts
node_modules/@types/babel__template/index.d.ts
node_modules/@types/babel__template/index.d.ts
node_modules/@types/babel__traverse/index.d.ts
node_modules/@types/node/globals.d.ts
📖 Docs