Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(models): add missing exports #918

Merged

Conversation

aramirezj
Copy link
Contributor

@aramirezj aramirezj commented Jan 10, 2025

Adds missing expected exports of fileNameSchema and filePathSchema of the package models

Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the existing formatting to reduce the diff

Copy link

github-actions bot commented Jan 10, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 6a74c2d with source commit 6a74c2d.

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 32 🟡 54 ↑ +21.9
Code coverage 🟢 91 🟢 91
Security 🟡 81 🟡 81
Updates 🟡 80 🟡 80
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👍 1 group improved, 👍 5 audits improved, 👎 3 audits regressed, 12 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 32 🟡 54 ↑ +21.9

16 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Largest Contentful Paint 🟥 9.4 s 🟨 3.2 s ↓ −65.7 %
Lighthouse Eliminate render-blocking resources 🟨 Potential savings of 0 ms 🟥 Potential savings of 1,030 ms ↑ +∞ %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 142 KiB 🟨 Potential savings of 142 KiB ↓ −100 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 85 KiB 🟨 Potential savings of 80 KiB ↓ −100 %
Lighthouse Speed Index 🟥 7.5 s 🟨 5.4 s ↓ −28.3 %
Lighthouse First Contentful Paint 🟥 3.3 s 🟨 2.8 s ↓ −14.1 %
Lighthouse Time to Interactive 🟥 12.2 s 🟥 13.6 s ↑ +11.9 %
Lighthouse Total Blocking Time 🟥 4,060 ms 🟥 4,650 ms ↑ +14.6 %
Lighthouse Minimizes main-thread work 🟥 12.5 s 🟥 14.8 s ↑ +18.6 %
Lighthouse JavaScript execution time 🟥 5.6 s 🟥 7.3 s ↑ +31.2 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +11.9 %
Lighthouse Max Potential First Input Delay 🟥 2,010 ms 🟥 1,690 ms ↓ −15.8 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,822 KiB 🟩 Total size was 1,822 KiB ↑ +0.1 %
Lighthouse Initial server response time was short 🟩 Root document took 320 ms 🟩 Root document took 440 ms ↑ +35.6 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 66 KiB 🟥 Potential savings of 66 KiB ↑ +36.7 %
Lighthouse Server Backend Latencies 🟩 260 ms 🟩 190 ms ↓ −25.8 %
Lighthouse Network Round Trip Times 🟩 0 ms 🟩 10 ms ↑ +522.4 %
Lighthouse Uses efficient cache policy on static assets 🟨 28 resources found 🟨 28 resources found ↓ −0.1 %
Lighthouse Avoid large layout shifts 🟩 0 🟩 1 layout shift found ↑ +∞ %
Lighthouse Cumulative Layout Shift 🟩 0 🟩 0 ↑ +∞ %

568 other audits are unchanged.

@BioPhoton BioPhoton merged commit 55c878f into code-pushup:main Jan 10, 2025
16 checks passed
@aramirezj aramirezj deleted the fix--missing-file-path-schema-from-index branch January 11, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants