Skip to content
This repository has been archived by the owner on May 15, 2021. It is now read-only.

Improved .admins #54

Merged
merged 5 commits into from
Oct 24, 2020
Merged

Improved .admins #54

merged 5 commits into from
Oct 24, 2020

Conversation

code-rgb
Copy link
Owner

No description provided.

@vercel
Copy link

vercel bot commented Oct 24, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/code-rgb/userge-x/r56euqr1f
✅ Preview: https://userge-x-git-develop.code-rgb.vercel.app

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 24, 2020

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 8.75%.

Quality metrics Before After Change
Complexity 24.00 😞 34.00 ⛔ 10.00 👎
Method Length 216.00 ⛔ 264.00 ⛔ 48.00 👎
Working memory 16.00 ⛔ 17.00 ⛔ 1.00 👎
Quality 27.71% 😞 18.96% -8.75% 👎
Other metrics Before After Change
Lines 54 66 12
Changed files Quality Before Quality After Quality Change
userge/plugins/utils/admins.py 27.71% 😞 18.96% ⛔ -8.75% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
userge/plugins/utils/admins.py mentionadmins 34 ⛔ 264 ⛔ 17 ⛔ 18.96% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@code-rgb code-rgb deleted the develop branch November 12, 2020 12:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant