Skip to content
This repository was archived by the owner on May 15, 2021. It is now read-only.

Rogue #63

Merged
merged 41 commits into from
Nov 21, 2020
Merged

Rogue #63

merged 41 commits into from
Nov 21, 2020

Conversation

code-rgb
Copy link
Owner

No description provided.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 21, 2020

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.92%.

Quality metrics Before After Change
Complexity 21.39 😞 20.93 😞 -0.46 👍
Method Length 96.66 🙂 94.82 🙂 -1.84 👍
Working memory 15.62 ⛔ 14.93 😞 -0.69 👍
Quality 49.38% 😞 50.30% 🙂 0.92% 👍
Other metrics Before After Change
Lines 7048 6933 -115
Changed files Quality Before Quality After Quality Change
tools/genStrSession.py 81.28% ⭐ 81.28% ⭐ 0.00%
userge/config.py 48.90% 😞 45.78% 😞 -3.12% 👎
userge/core/client.py 74.35% 🙂 72.12% 🙂 -2.23% 👎
userge/core/ext/pool.py 86.20% ⭐ 85.33% ⭐ -0.87% 👎
userge/core/types/new/conversation.py 76.41% ⭐ 76.32% ⭐ -0.09% 👎
userge/core/types/raw/command.py 25.28% 😞 25.28% 😞 0.00%
userge/plugins/help.py 27.68% 😞 28.69% 😞 1.01% 👍
userge/plugins/admin/gadmin.py 34.42% 😞 33.99% 😞 -0.43% 👎
userge/plugins/admin/privacy.py 59.81% 🙂 59.22% 🙂 -0.59% 👎
userge/plugins/bot/bot_forwards.py 57.87% 🙂 54.92% 🙂 -2.95% 👎
userge/plugins/bot/bot_pm.py 55.48% 🙂 55.48% 🙂 0.00%
userge/plugins/bot/gapps.py 55.55% 🙂 55.55% 🙂 0.00%
userge/plugins/bot/opinion.py 30.13% 😞 30.13% 😞 0.00%
userge/plugins/bot/secret.py 60.42% 🙂 59.29% 🙂 -1.13% 👎
userge/plugins/bot/spoiler.py 54.21% 🙂 54.21% 🙂 0.00%
userge/plugins/bot/utube_inline.py 53.62% 🙂 46.29% 😞 -7.33% 👎
userge/plugins/fun/gizoogle.py 78.00% ⭐ 78.00% ⭐ 0.00%
userge/plugins/fun/nekos.py 46.43% 😞 48.30% 😞 1.87% 👍
userge/plugins/fun/nsfw.py 70.51% 🙂 70.51% 🙂 0.00%
userge/plugins/fun/spotify_autobio.py 37.38% 😞 37.25% 😞 -0.13% 👎
userge/plugins/misc/download.py 17.06% ⛔ 49.19% 😞 32.13% 👍
userge/plugins/misc/gdrive.py 60.22% 🙂 63.77% 🙂 3.55% 👍
userge/plugins/misc/upload.py 41.24% 😞 47.19% 😞 5.95% 👍
userge/plugins/tools/json.py 77.97% ⭐ 77.97% ⭐ 0.00%
userge/plugins/tools/neofetch.py 46.57% 😞 47.27% 😞 0.70% 👍
userge/plugins/tools/updater.py 43.02% 😞 42.74% 😞 -0.28% 👎
userge/plugins/utils/direct_links.py 56.53% 🙂 55.85% 🙂 -0.68% 👎
userge/plugins/utils/notes.py 55.25% 🙂 55.25% 🙂 0.00%
userge/utils/helper/aiohttp_helper.py 94.51% ⭐ 94.51% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
userge/plugins/help.py inline_answer 174 ⛔ 1642 ⛔ 42 ⛔ 0.13% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
userge/plugins/fun/spotify_autobio.py spotify_biox 95 ⛔ 692 ⛔ 23 ⛔ 2.91% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
userge/plugins/bot/opinion.py choice_cb 38 ⛔ 535 ⛔ 19 ⛔ 11.32% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
userge/plugins/admin/gadmin.py zombie_clean 34 ⛔ 300 ⛔ 18 ⛔ 16.69% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
userge/core/types/raw/command.py _format_about 51 ⛔ 375 ⛔ 12 😞 17.44% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@sourcery-ai sourcery-ai bot mentioned this pull request Nov 21, 2020
@code-rgb code-rgb merged commit d637b0e into alpha Nov 21, 2020
@code-rgb code-rgb deleted the fixes branch November 21, 2020 12:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant