Skip to content
This repository has been archived by the owner on May 15, 2021. It is now read-only.

deepsouce fixes #66

Merged
merged 1 commit into from
Nov 21, 2020
Merged

deepsouce fixes #66

merged 1 commit into from
Nov 21, 2020

Conversation

code-rgb
Copy link
Owner

No description provided.

@code-rgb code-rgb merged commit 731c834 into alpha Nov 21, 2020
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 21, 2020

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.24%.

Quality metrics Before After Change
Complexity 11.00 🙂 10.96 🙂 -0.04 👍
Method Length 130.07 😞 129.71 😞 -0.36 👍
Working memory 16.75 ⛔ 16.59 ⛔ -0.16 👍
Quality 43.23% 😞 43.47% 😞 0.24% 👍
Other metrics Before After Change
Lines 554 552 -2
Changed files Quality Before Quality After Quality Change
userge/plugins/admin/gban.py 45.82% 😞 45.82% 😞 0.00%
userge/plugins/fun/quote.py 24.43% ⛔ 25.53% 😞 1.10% 👍
userge/plugins/utils/telegraph.py 53.18% 🙂 53.78% 🙂 0.60% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
userge/plugins/admin/gban.py gban_at_entry 22 😞 321 ⛔ 28 ⛔ 18.10% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
userge/plugins/fun/quote.py quotecmd 25 😞 242 ⛔ 16 ⛔ 25.53% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
userge/plugins/admin/gban.py gban_user 11 🙂 274 ⛔ 17 ⛔ 33.57% 😞 Try splitting into smaller methods. Extract out complex expressions
userge/plugins/utils/telegraph.py upload_media_ 7 ⭐ 129 😞 21 ⛔ 45.53% 😞 Try splitting into smaller methods. Extract out complex expressions
userge/plugins/admin/gban.py ungban_user 9 🙂 188 😞 11 😞 48.67% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant