Skip to content
This repository has been archived by the owner on May 15, 2021. It is now read-only.

Inline Buttons 2.0 #76

Merged
merged 40 commits into from
Nov 29, 2020
Merged

Inline Buttons 2.0 #76

merged 40 commits into from
Nov 29, 2020

Conversation

code-rgb
Copy link
Owner

No description provided.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 29, 2020

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.73%.

Quality metrics Before After Change
Complexity 55.21 ⛔ 71.05 ⛔ 15.84 👎
Method Length 108.94 🙂 107.69 🙂 -1.25 👍
Working memory 21.05 ⛔ 21.41 ⛔ 0.36 👎
Quality 40.35% 😞 39.62% 😞 -0.73% 👎
Other metrics Before After Change
Lines 1624 1708 84
Changed files Quality Before Quality After Quality Change
userge/plugins/help.py 28.69% 😞 27.25% 😞 -1.44% 👎
userge/plugins/bot/bot_forwards.py 55.20% 🙂 55.06% 🙂 -0.14% 👎
userge/plugins/bot/buttons.py 48.04% 😞 51.07% 🙂 3.03% 👍
userge/utils/spotify/spotify_db_class.py 95.29% ⭐ 95.29% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
userge/plugins/help.py inline_answer 217 ⛔ 1815 ⛔ 42 ⛔ 0.13% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
userge/plugins/help.py helpme 20 😞 261 ⛔ 22 ⛔ 23.49% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
userge/plugins/bot/buttons.py noformat_message 25 😞 189 😞 16 ⛔ 29.10% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
userge/plugins/help.py plugin_data 5 ⭐ 210 ⛔ 20 ⛔ 40.44% 😞 Try splitting into smaller methods. Extract out complex expressions
userge/plugins/bot/bot_forwards.py bot_ban_ 5 ⭐ 189 😞 17 ⛔ 44.32% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@code-rgb code-rgb merged commit a377525 into release Nov 29, 2020
@code-rgb code-rgb deleted the inline branch November 29, 2020 05:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant