-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! We will fix the any
s later 👍 Good to see the fork go!
"nuka-carousel": "^4.2.5", | ||
"prettier": "^1.10.2", | ||
"react": "^16.4.0", | ||
"react-dom": "^16.4.0", | ||
"react-ga": "^2.5.3", | ||
"react-i18next": "^7.7.0", | ||
"react-router-dom": "^4.2.2", | ||
"react-scripts-ts": "https://github.com/code-star/create-react-app-typescript.git#build", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
@@ -61,6 +61,6 @@ const Events: SFC<IEventInnerProps & IEventOuterProps> = ({ | |||
); | |||
}; | |||
|
|||
export default compose<IEventInnerProps, IEventOuterProps>( | |||
export default compose<IEventInnerProps & IEventOuterProps, IEventOuterProps>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
.gitignore
Outdated
@@ -26,8 +26,8 @@ yarn-error.log* | |||
# Serverless directories | |||
.serverless | |||
|
|||
# Do not use yarn | |||
yarn.lock | |||
# Do not npm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"use"
I do want to note I am getting this runtime error:
|
I am also getting an enormous amount of TS errors in the IDE, but not in the build: e.g. in About.tsx
|
This PR removes
react-scripts-ts
and addstypescript
support with the officialreact-scripts
.Besides
any
)PS: if you have errors running the tests it is a [know NPM issue}(https://github.com/facebook/create-react-app/issues/5259).
Followed https://vincenttunru.com/migrate-create-react-app-typescript-to-create-react-app/
Update
For the same npm issue described above, Travis was not passing, therefore this PR will ensure that you use Yarn for package manager