fix: handle both string[] and object[] formats in provider-models cache

[rooftop-Owl]

Summary

Fixes category delegation failing when provider-models.json contains model objects with metadata instead of plain strings.

Root Cause: Line 196 in model-availability.ts assumes string[] format when iterating over cached models, but manually-populated caches (like Ollama) use object[] format with metadata ({id, provider, context, output}).

Impact:

• delegate_task(category='quick') → ❌ "Model not configured for category"
• delegate_task(subagent_type='explore') → ✅ Works (bypasses cache)

Changes

Core Fix (model-availability.ts)

// Before (line 196)
for (const modelId of modelIds) {
  modelSet.add(`${providerId}/${modelId}`)  // ❌ Breaks with objects
}

// After
for (const modelItem of modelIds) {
  const modelId = typeof modelItem === 'string' 
    ? modelItem 
    : (modelItem as any)?.id  // ✅ Handles both formats
  
  if (modelId) {
    modelSet.add(`${providerId}/${modelId}`)
  }
}

Type Safety (connected-providers-cache.ts)

interface ProviderModelsCache {
  models: Record<string, string[] | ModelMetadata[]>  // Now accepts both
  connected: string[]
  updatedAt: string
}

Test Coverage (model-availability.test.ts)

Added 4 test cases:

• ✅ Handle object[] format with metadata (Ollama-style)
• ✅ Handle mixed string[] and object[] across providers
• ✅ Skip invalid entries gracefully
• ✅ Backward compatibility with legacy string[] format

Testing

npm test -- src/shared/model-availability.test.ts
# ✅ 48 pass (including 4 new tests)

npm run typecheck
# ✅ No errors

Context

This fix enables category-based delegation to work with manually-populated Ollama model caches, which is the intended approach per Vercel AI SDK (no model.list() for local providers).

Related:

• Fixes [Bug]: Category delegation fails to resolve Ollama models despite correct configuration #1508
• Complements PR docs: add Ollama streaming NDJSON issue guide and workaround #1197 (NDJSON streaming fix)

Backward Compatibility

✅ Fully backward compatible - handles both legacy string[] and new object[] formats without breaking existing deployments.

---

Summary by cubic

Fixes category delegation by supporting both string[] and object[] formats in provider-models.json. Prevents “Model not configured for category” errors with Ollama and other manually populated caches.

• Bug Fixes
  • Parse both string[] and object[] when building available models; skip invalid entries.
  • Updated ProviderModelsCache types and added tests for object[], mixed formats, and legacy compatibility.

^{Written for commit bd3a3bc. Summary will update on new commits.}

[cubic-dev-ai]

No issues found across 3 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.