Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: Fixed hidden closing button of Sidebar #1561

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Zopsss
Copy link

@Zopsss Zopsss commented Nov 12, 2024

Fixed closing button of the sidebar.

Before:
Screenshot (377)

After:
Screenshot (376)

Changed CSS from top-0 to top-[64px]... WHY 64PX??

Explanation:

In tailwind.config.js, we have defined height of the sidebar as 100vh-64px:

cms/tailwind.config.js

Lines 87 to 89 in 204c496

height: {
sidebar: 'calc(100vh - 64px)',
},

Similarly in tailwind.css:

cms/src/styles/tailwind.css

Lines 1053 to 1055 in 204c496

.h-sidebar {
height: calc(100vh - 64px);
}

But the sidebar had inline TailwindCSS in which we defined top-0 so it was sticking to the top and was getting covered by navbar.

@Zopsss
Copy link
Author

Zopsss commented Nov 14, 2024

@devsargam please review once you get some free time

@hkirat
Copy link
Contributor

hkirat commented Nov 15, 2024

@devsargam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants