minor: Fixed hidden closing button of Sidebar #1561
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed closing button of the sidebar.
Before:
After:
Changed CSS from
top-0
totop-[64px]
... WHY 64PX??Explanation:
In tailwind.config.js, we have defined height of the sidebar as
100vh-64px
:cms/tailwind.config.js
Lines 87 to 89 in 204c496
Similarly in tailwind.css:
cms/src/styles/tailwind.css
Lines 1053 to 1055 in 204c496
But the sidebar had inline TailwindCSS in which we defined
top-0
so it was sticking to the top and was getting covered by navbar.